🐛 fix issue on RiskStewards contract name for same chain pools #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotherlymite
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the generator doesn't use the right
RiskStewardscontract name on the file it generates. It uses the chain name instead of the pool name. So pools like Lido or Etherfi use the sameRiskStewardsEthereuminstead of their own.This leads to the execution of calldatas that return errors because they are simulated on the wrong RiskStewards address.
Instead of getting the chain name to compute the
RiskStewardscontract name, we now use the suffix of Pool names.So:
AaveV3EthereumLido=>EthereumLidoTested locally contract on Core and Prime pool: ✅