Modify GhoReserve and Facilitator AccessControl #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelmtzinf
reviewed
Jan 5, 2026
miguelmtzinf
reviewed
Jan 5, 2026
src/contracts/facilitators/gsm/interfaces/IGhoDirectFacilitator.sol
Outdated
Show resolved
Hide resolved
miguelmtzinf
reviewed
Jan 5, 2026
src/contracts/facilitators/gsm/interfaces/IGhoDirectFacilitator.sol
Outdated
Show resolved
Hide resolved
miguelmtzinf
reviewed
Jan 5, 2026
miguelmtzinf
reviewed
Jan 5, 2026
miguelmtzinf
reviewed
Jan 5, 2026
src/contracts/facilitators/gsm/interfaces/IGhoDirectFacilitator.sol
Outdated
Show resolved
Hide resolved
miguelmtzinf
reviewed
Jan 5, 2026
miguelmtzinf
reviewed
Jan 5, 2026
miguelmtzinf
reviewed
Jan 5, 2026
miguelmtzinf
reviewed
Jan 5, 2026
Comment on lines
55
to
58
| _grantRole(DEFAULT_ADMIN_ROLE, admin); | ||
| _grantRole(MANAGE_ENTITY_ROLE, admin); | ||
| _grantRole(SET_LIMIT_ROLE, admin); | ||
| _grantRole(TRANSFER_ROLE, admin); |
Collaborator
There was a problem hiding this comment.
we could only give default admin role, but i'm fine with this given that most likely it d be assigned to the Executor.
(sme in GhoDirectFacilitator)
Collaborator
Author
|
@miguelmtzinf updated, thank you |
miguelmtzinf
changed the base branch from
main
to
tokenlogic/gho-reserve-steward
miguelmtzinf
approved these changes
Jan 7, 2026
Collaborator
miguelmtzinf
left a comment
miguelmtzinf
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for addressing comments!
miguelmtzinf
merged commit 888e965
into
aave-dao:tokenlogic/gho-reserve-steward
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Modify access control from Ownable to AccessControl.
Update tests and specs accordingly.