fix : modify GSM signature encoding #8
Merged
+293
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
closes #10 |
Kogaroshi
force-pushed
the
fix/gsm-sig-encoding
branch
from
0734434 to
86dc0ee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
![certora-run[bot]](https://avatars.githubusercontent.com/in/1083145?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
There was a problem hiding this comment.
should we git-ignore this file? as it's automatically generated
Collaborator
Author
There was a problem hiding this comment.
it was generated using forge bind-json, it is done once and not needed to be automatic or re-created as long as new types are not introduced or the current ones modified
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
There was a problem hiding this comment.
Verification Results
- Group ID: 1ad534b1-1c75-40bc-9983-bd4a102a184e
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| verifyUpgradeableGhoToken.conf | ✅ | 29 | Link |
| verifyGhoVariableDebtToken_summarized.conf --rule accrueAlwaysCalleldBeforeRefresh | ✅ | 2 | Link |
| verifyGhoVariableDebtToken_specialBranch.conf --rule sendersDiscountPercentCannotIncrease | ✅ | 2 | Link |
| verifyGhoVariableDebtToken-rayMulDiv-summarization.conf | ✅ | 8 | Link |
| verifyGhoVariableDebtTokenInternal.conf | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule user_index_after_mint user_index_ge_one_ray nonzeroNewDiscountToken | ✅ | 4 | Link |
| verifyGhoVariableDebtToken.conf --rule userCantNullifyItsDebt | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule onlyMintForUserCanIncreaseUsersBalance | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceedDiscountRate | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceed100Percent | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule accumulated_interest_increase_after_mint | ✅ | 2 | Link |
| verifyGhoToken.conf | ✅ | 29 | Link |
| verifyGhoDiscountRateStrategy.conf --rule equivalenceOfWadMulCVLAndWadMulSol maxDiscountForHighDiscountTokenBalance zeroDiscountForSmallDiscountTokenBalance partialDiscountForIntermediateTokenBalance limitOnDiscountRate | ✅ | 6 | Link |
| verifyGhoAToken.conf --rule noMint noBurn noTransfer transferUnderlyingToCantExceedCapacity totalSupplyAlwaysZero userBalanceAlwaysZero level_does_not_decrease_after_transferUnderlyingTo_followed_by_handleRepayment | ✅ | 8 | Link |
| verifyFlashMinter.conf --rule balanceOfFlashMinterGrows integrityOfTreasurySet integrityOfFeeSet availableLiquidityDoesntChange integrityOfDistributeFeesToTreasury feeSimulationEqualsActualFee | ✅ | 7 | Link |
| scountPercent_userIsolation integrityOfBalanceOf_fullDiscount integrityOfBalanceOf_noDiscount integrityOfBalanceOf_zeroScaledBalance burnAllDebtReturnsZeroDebt integrityOfUpdateDiscountRateStrategy user_index_up_to_date | ✅ | 28 | Link |
There was a problem hiding this comment.
Verification Results
- Group ID: 23edbe02-d27d-417c-bb21-691786b4f372
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| verifyUpgradeableGhoToken.conf | ✅ | 0 | Link |
| verifyGhoVariableDebtToken_summarized.conf --rule accrueAlwaysCalleldBeforeRefresh | ✅ | 2 | Link |
| verifyGhoVariableDebtToken_specialBranch.conf --rule sendersDiscountPercentCannotIncrease | ✅ | 2 | Link |
| verifyGhoVariableDebtToken-rayMulDiv-summarization.conf | ✅ | 8 | Link |
| verifyGhoVariableDebtTokenInternal.conf | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule user_index_after_mint user_index_ge_one_ray nonzeroNewDiscountToken | ✅ | 4 | Link |
| verifyGhoVariableDebtToken.conf --rule userCantNullifyItsDebt | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule onlyMintForUserCanIncreaseUsersBalance | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceedDiscountRate | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceed100Percent | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule accumulated_interest_increase_after_mint | ✅ | 2 | Link |
| verifyGhoToken.conf | ✅ | 29 | Link |
| verifyGhoDiscountRateStrategy.conf --rule equivalenceOfWadMulCVLAndWadMulSol maxDiscountForHighDiscountTokenBalance zeroDiscountForSmallDiscountTokenBalance partialDiscountForIntermediateTokenBalance limitOnDiscountRate | ✅ | 6 | Link |
| verifyGhoAToken.conf --rule noMint noBurn noTransfer transferUnderlyingToCantExceedCapacity totalSupplyAlwaysZero userBalanceAlwaysZero level_does_not_decrease_after_transferUnderlyingTo_followed_by_handleRepayment | ✅ | 8 | Link |
| verifyFlashMinter.conf --rule balanceOfFlashMinterGrows integrityOfTreasurySet integrityOfFeeSet availableLiquidityDoesntChange integrityOfDistributeFeesToTreasury feeSimulationEqualsActualFee | ✅ | 7 | Link |
| scountPercent_userIsolation integrityOfBalanceOf_fullDiscount integrityOfBalanceOf_noDiscount integrityOfBalanceOf_zeroScaledBalance burnAllDebtReturnsZeroDebt integrityOfUpdateDiscountRateStrategy user_index_up_to_date | ✅ | 28 | Link |
There was a problem hiding this comment.
Verification Results
- Group ID: e3dd0c7f-8123-4b7a-b803-29e351d2aa13
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| set R1a_getAssetAmountForSellAssetFeeNeGetSellFee R2a_getAssetAmountForSellAssetNeActualSellFee R4b_getSellFeeVsgetAssetAmountForSellAsset R1_getAssetAmountForSellAssetFeeGeGetSellFee R3b_estimatedSellFeeEqActualSellFee | ✅ | 10 | Link |
| orrectness_bound1 getAssetAmountForBuyAsset_correctness_bound2 getGhoAmountForBuyAsset_correctness_bound1 getAssetAmountForSellAsset_correctness getAssetAmountForBuyAsset_optimality getAssetAmountForBuyAsset_correctness | ✅ | 7 | Link |
| optimality4626.conf --rule R5a_externalOptimalityOfSellAsset R6a_externalOptimalityOfBuyAsset | ✅ | 3 | Link |
| optimality4626.conf --rule R3_optimalityOfSellAsset_v1 | ✅ | 2 | Link |
| optimality4626.conf --rule R1_optimalityOfBuyAsset_v1 | ✅ | 2 | Link |
| gho-gsm4626-inverse.conf --rule buySellInverse27 buySellInverse26 buySellInverse25 buySellInverse24 buySellInverse23 buySellInverse22 buySellInverse21 buySellInverse20 buySellInverse19 | ✅ | 10 | Link |
| gho-gsm4626-2.conf --rule accruedFeesNeverDecrease | ✅ | 2 | Link |
| gho-gsm4626-2.conf --rule accruedFeesLEGhoBalanceOfThis | ✅ | 2 | Link |
| gho-gsm4626-1.conf | ✅ | 4 | Link |
| getAmount-properties-4626.conf --rule getGhoAmountForBuyAsset_optimality | ✅ | 2 | Link |
| getAmount-properties-4626.conf --rule getGhoAmountForBuyAsset_correctness | ✅ | 2 | Link |
| getAmount-properties-4626.conf --rule getAssetAmountForSellAsset_optimality getAssetAmountForBuyAsset_funcProperty | ✅ | 3 | Link |
| finishedRules-4626.conf --rule giftingUnderlyingDoesntCreateExcessOrDearth | ✅ | 2 | Link |
| fees-buy-4626.conf | ✅ | 8 | Link |
| edSellFeeIsAtLeastAsRequired collectedBuyFeePlus2IsAtLeastAsRequired collectedBuyFeePlus1IsAtLeastAsRequired collectedBuyFeeIsAtLeastAsRequired sellingDoesntExceedExposureCap whoCanChangeAccruedFees whoCanChangeExposure | ✅ | 22 | Link |
| balances-sell-4626.conf --rule R4_buyGhoUpdatesGhoBalanceCorrectly R4a_buyGhoAmountGtGhoBalanceChange | ✅ | 3 | Link |
| balances-sell-4626.conf --rule R3a_sellAssetUpdatesAssetBalanceCorrectly | ✅ | 2 | Link |
| balances-sell-4626.conf --rule R1_getAssetAmountForSellAsset_arg_vs_return R1a_buyGhoUpdatesGhoBalanceCorrectly1 R2_getAssetAmountForSellAsset_sellAsset_eq | ✅ | 4 | Link |
| balances-buy-4626.conf | ✅ | 8 | Link |
miguelmtzinf
reviewed
Sep 1, 2025
miguelmtzinf
reviewed
Sep 1, 2025
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
There was a problem hiding this comment.
Verification Results
- Group ID: 24e9fb68-42ed-4ea3-bfaf-5257a8df00a1
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| ssetAmountForSellAsset_correctness cantBuyOrSellWhenFrozen whoCanChangeExposureCap cantSellIfExposureTooHigh sellAssetIncreasesExposure buyAssetDecreasesExposure rescuingGhoKeepsAccruedFees rescuingAssetKeepsAccruedFees | ✅ | 21 | Link |
| OracleSwapFreezer.conf | ✅ | 5 | Link |
| optimality.conf --rule R3_optimalityOfSellAsset_v1 R1_optimalityOfBuyAsset_v1 R6a_externalOptimalityOfBuyAsset R5a_externalOptimalityOfSellAsset R2_optimalityOfBuyAsset_v2 | ✅ | 6 | Link |
| gho-gsm-inverse.conf | ✅ | 24 | Link |
| gho-gsm-2.conf | ✅ | 6 | Link |
| gho-gsm-1.conf | ✅ | 7 | Link |
| gho-fixedPriceStrategy.conf | ✅ | 5 | Link |
| gho-assetToGhoInvertibility.conf --rule basicProperty_getAssetAmountForBuyAsset sellAssetInverse_all buyAssetInverse_all basicProperty_getGhoAmountForSellAsset basicProperty_getAssetAmountForSellAsset basicProperty_getGhoAmountForBuyAsset | ✅ | 7 | Link |
| gho-assetToGhoInvertibility.conf --rule basicProperty2_getAssetAmountForBuyAsset | ✅ | 2 | Link |
| getAmount_properties.conf --rule getAssetAmountForBuyAsset_funcProperty_LR getAssetAmountForBuyAsset_funcProperty_RL | ✅ | 3 | Link |
| FixedFeeStrategy.conf | ✅ | 11 | Link |
| fees-sell.conf --rule R3_estimatedSellFeeCanBeHigherThanActualSellFee | ✅ | 2 | Link |
| fees-sell.conf --exclude_rule R3_estimatedSellFeeCanBeHigherThanActualSellFee | ✅ | 8 | Link |
| fees-buy.conf | ✅ | 8 | Link |
| balances-sell.conf --exclude_rule R3_sellAssetUpdatesAssetBalanceCorrectly R4_buyGhoUpdatesGhoBalanceCorrectly | ✅ | 6 | Link |
| balances-buy.conf | ✅ | 11 | Link |
There was a problem hiding this comment.
Verification Results
- Group ID: 34f65591-20c0-4fd9-ab90-54006dd35807
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| verifyUpgradeableGhoToken.conf | ✅ | 29 | Link |
| verifyGhoVariableDebtToken_summarized.conf --rule accrueAlwaysCalleldBeforeRefresh | ✅ | 2 | Link |
| verifyGhoVariableDebtToken_specialBranch.conf --rule sendersDiscountPercentCannotIncrease | ✅ | 2 | Link |
| verifyGhoVariableDebtToken-rayMulDiv-summarization.conf | ✅ | 8 | Link |
| verifyGhoVariableDebtTokenInternal.conf | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule user_index_after_mint user_index_ge_one_ray nonzeroNewDiscountToken | ✅ | 4 | Link |
| verifyGhoVariableDebtToken.conf --rule userCantNullifyItsDebt | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule onlyMintForUserCanIncreaseUsersBalance | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceedDiscountRate | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceed100Percent | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule accumulated_interest_increase_after_mint | ✅ | 2 | Link |
| verifyGhoToken.conf | ✅ | 29 | Link |
| verifyGhoDiscountRateStrategy.conf --rule equivalenceOfWadMulCVLAndWadMulSol maxDiscountForHighDiscountTokenBalance zeroDiscountForSmallDiscountTokenBalance partialDiscountForIntermediateTokenBalance limitOnDiscountRate | ✅ | 6 | Link |
| verifyGhoAToken.conf --rule noMint noBurn noTransfer transferUnderlyingToCantExceedCapacity totalSupplyAlwaysZero userBalanceAlwaysZero level_does_not_decrease_after_transferUnderlyingTo_followed_by_handleRepayment | ✅ | 8 | Link |
| verifyFlashMinter.conf --rule balanceOfFlashMinterGrows integrityOfTreasurySet integrityOfFeeSet availableLiquidityDoesntChange integrityOfDistributeFeesToTreasury feeSimulationEqualsActualFee | ✅ | 7 | Link |
| scountPercent_userIsolation integrityOfBalanceOf_fullDiscount integrityOfBalanceOf_noDiscount integrityOfBalanceOf_zeroScaledBalance burnAllDebtReturnsZeroDebt integrityOfUpdateDiscountRateStrategy user_index_up_to_date | ✅ | 28 | Link |
There was a problem hiding this comment.
Verification Results
- Group ID: 1cef23be-6fce-4339-9e4b-10cc5cdf5da9
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| set R1a_getAssetAmountForSellAssetFeeNeGetSellFee R2a_getAssetAmountForSellAssetNeActualSellFee R4b_getSellFeeVsgetAssetAmountForSellAsset R1_getAssetAmountForSellAssetFeeGeGetSellFee R3b_estimatedSellFeeEqActualSellFee | ✅ | 10 | Link |
| orrectness_bound1 getAssetAmountForBuyAsset_correctness_bound2 getGhoAmountForBuyAsset_correctness_bound1 getAssetAmountForSellAsset_correctness getAssetAmountForBuyAsset_optimality getAssetAmountForBuyAsset_correctness | ✅ | 7 | Link |
| optimality4626.conf --rule R5a_externalOptimalityOfSellAsset R6a_externalOptimalityOfBuyAsset | ✅ | 3 | Link |
| optimality4626.conf --rule R3_optimalityOfSellAsset_v1 | ✅ | 2 | Link |
| optimality4626.conf --rule R1_optimalityOfBuyAsset_v1 | ✅ | 2 | Link |
| gho-gsm4626-inverse.conf --rule buySellInverse27 buySellInverse26 buySellInverse25 buySellInverse24 buySellInverse23 buySellInverse22 buySellInverse21 buySellInverse20 buySellInverse19 | ✅ | 10 | Link |
| gho-gsm4626-2.conf --rule accruedFeesNeverDecrease | ✅ | 2 | Link |
| gho-gsm4626-2.conf --rule accruedFeesLEGhoBalanceOfThis | ✅ | 2 | Link |
| gho-gsm4626-1.conf | ✅ | 4 | Link |
| getAmount-properties-4626.conf --rule getGhoAmountForBuyAsset_optimality | ✅ | 2 | Link |
| getAmount-properties-4626.conf --rule getGhoAmountForBuyAsset_correctness | ✅ | 2 | Link |
| getAmount-properties-4626.conf --rule getAssetAmountForSellAsset_optimality getAssetAmountForBuyAsset_funcProperty | ✅ | 3 | Link |
| finishedRules-4626.conf --rule giftingUnderlyingDoesntCreateExcessOrDearth | ✅ | 2 | Link |
| fees-buy-4626.conf | ✅ | 8 | Link |
| edSellFeeIsAtLeastAsRequired collectedBuyFeePlus2IsAtLeastAsRequired collectedBuyFeePlus1IsAtLeastAsRequired collectedBuyFeeIsAtLeastAsRequired sellingDoesntExceedExposureCap whoCanChangeAccruedFees whoCanChangeExposure | ✅ | 22 | Link |
| balances-sell-4626.conf --rule R4_buyGhoUpdatesGhoBalanceCorrectly R4a_buyGhoAmountGtGhoBalanceChange | ✅ | 3 | Link |
| balances-sell-4626.conf --rule R3a_sellAssetUpdatesAssetBalanceCorrectly | ✅ | 2 | Link |
| balances-sell-4626.conf --rule R1_getAssetAmountForSellAsset_arg_vs_return R1a_buyGhoUpdatesGhoBalanceCorrectly1 R2_getAssetAmountForSellAsset_sellAsset_eq | ✅ | 4 | Link |
| balances-buy-4626.conf | ✅ | 8 | Link |
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
There was a problem hiding this comment.
Verification Results
- Group ID: 2e0b3572-5a7a-4482-add5-eb5ff47aaef8
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| verifyUpgradeableGhoToken.conf | ✅ | 29 | Link |
| verifyGhoVariableDebtToken_summarized.conf --rule accrueAlwaysCalleldBeforeRefresh | ✅ | 2 | Link |
| verifyGhoVariableDebtToken_specialBranch.conf --rule sendersDiscountPercentCannotIncrease | ✅ | 2 | Link |
| verifyGhoVariableDebtToken-rayMulDiv-summarization.conf | ✅ | 8 | Link |
| verifyGhoVariableDebtTokenInternal.conf | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule user_index_after_mint user_index_ge_one_ray nonzeroNewDiscountToken | ✅ | 4 | Link |
| verifyGhoVariableDebtToken.conf --rule userCantNullifyItsDebt | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule onlyMintForUserCanIncreaseUsersBalance | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceedDiscountRate | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule discountCantExceed100Percent | ✅ | 2 | Link |
| verifyGhoVariableDebtToken.conf --rule accumulated_interest_increase_after_mint | ✅ | 2 | Link |
| verifyGhoToken.conf | ✅ | 29 | Link |
| verifyGhoDiscountRateStrategy.conf --rule equivalenceOfWadMulCVLAndWadMulSol maxDiscountForHighDiscountTokenBalance zeroDiscountForSmallDiscountTokenBalance partialDiscountForIntermediateTokenBalance limitOnDiscountRate | ✅ | 6 | Link |
| verifyGhoAToken.conf --rule noMint noBurn noTransfer transferUnderlyingToCantExceedCapacity totalSupplyAlwaysZero userBalanceAlwaysZero level_does_not_decrease_after_transferUnderlyingTo_followed_by_handleRepayment | ✅ | 8 | Link |
| verifyFlashMinter.conf --rule balanceOfFlashMinterGrows integrityOfTreasurySet integrityOfFeeSet availableLiquidityDoesntChange integrityOfDistributeFeesToTreasury feeSimulationEqualsActualFee | ✅ | 7 | Link |
| scountPercent_userIsolation integrityOfBalanceOf_fullDiscount integrityOfBalanceOf_noDiscount integrityOfBalanceOf_zeroScaledBalance burnAllDebtReturnsZeroDebt integrityOfUpdateDiscountRateStrategy user_index_up_to_date | ✅ | 28 | Link |
There was a problem hiding this comment.
Verification Results
- Group ID: 5701feb6-74b5-4365-b883-a86321d129db
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| ssetAmountForSellAsset_correctness cantBuyOrSellWhenFrozen whoCanChangeExposureCap cantSellIfExposureTooHigh sellAssetIncreasesExposure buyAssetDecreasesExposure rescuingGhoKeepsAccruedFees rescuingAssetKeepsAccruedFees | ✅ | 21 | Link |
| OracleSwapFreezer.conf | ✅ | 5 | Link |
| optimality.conf --rule R3_optimalityOfSellAsset_v1 R1_optimalityOfBuyAsset_v1 R6a_externalOptimalityOfBuyAsset R5a_externalOptimalityOfSellAsset R2_optimalityOfBuyAsset_v2 | ✅ | 6 | Link |
| gho-gsm-inverse.conf | ✅ | 24 | Link |
| gho-gsm-2.conf | ✅ | 6 | Link |
| gho-gsm-1.conf | ✅ | 7 | Link |
| gho-fixedPriceStrategy.conf | ✅ | 5 | Link |
| gho-assetToGhoInvertibility.conf --rule basicProperty_getAssetAmountForBuyAsset sellAssetInverse_all buyAssetInverse_all basicProperty_getGhoAmountForSellAsset basicProperty_getAssetAmountForSellAsset basicProperty_getGhoAmountForBuyAsset | ✅ | 7 | Link |
| gho-assetToGhoInvertibility.conf --rule basicProperty2_getAssetAmountForBuyAsset | ✅ | 2 | Link |
| getAmount_properties.conf --rule getAssetAmountForBuyAsset_funcProperty_LR getAssetAmountForBuyAsset_funcProperty_RL | ✅ | 3 | Link |
| FixedFeeStrategy.conf | ✅ | 11 | Link |
| fees-sell.conf --rule R3_estimatedSellFeeCanBeHigherThanActualSellFee | ✅ | 2 | Link |
| fees-sell.conf --exclude_rule R3_estimatedSellFeeCanBeHigherThanActualSellFee | ✅ | 8 | Link |
| fees-buy.conf | ✅ | 8 | Link |
| balances-sell.conf --exclude_rule R3_sellAssetUpdatesAssetBalanceCorrectly R4_buyGhoUpdatesGhoBalanceCorrectly | ✅ | 6 | Link |
| balances-buy.conf | ✅ | 11 | Link |
There was a problem hiding this comment.
Verification Results
- Group ID: efcd54e7-0a3d-4e02-8e6a-e3825fad6138
| Job | Result | VERIFIED | Link |
|---|---|---|---|
| set R1a_getAssetAmountForSellAssetFeeNeGetSellFee R2a_getAssetAmountForSellAssetNeActualSellFee R4b_getSellFeeVsgetAssetAmountForSellAsset R1_getAssetAmountForSellAssetFeeGeGetSellFee R3b_estimatedSellFeeEqActualSellFee | ✅ | 10 | Link |
| orrectness_bound1 getAssetAmountForBuyAsset_correctness_bound2 getGhoAmountForBuyAsset_correctness_bound1 getAssetAmountForSellAsset_correctness getAssetAmountForBuyAsset_optimality getAssetAmountForBuyAsset_correctness | ✅ | 7 | Link |
| optimality4626.conf --rule R5a_externalOptimalityOfSellAsset R6a_externalOptimalityOfBuyAsset | ✅ | 3 | Link |
| optimality4626.conf --rule R3_optimalityOfSellAsset_v1 | ✅ | 2 | Link |
| optimality4626.conf --rule R1_optimalityOfBuyAsset_v1 | ✅ | 2 | Link |
| gho-gsm4626-inverse.conf --rule buySellInverse27 buySellInverse26 buySellInverse25 buySellInverse24 buySellInverse23 buySellInverse22 buySellInverse21 buySellInverse20 buySellInverse19 | ✅ | 10 | Link |
| gho-gsm4626-2.conf --rule accruedFeesNeverDecrease | ✅ | 2 | Link |
| gho-gsm4626-2.conf --rule accruedFeesLEGhoBalanceOfThis | ✅ | 2 | Link |
| gho-gsm4626-1.conf | ✅ | 4 | Link |
| getAmount-properties-4626.conf --rule getGhoAmountForBuyAsset_optimality | ✅ | 2 | Link |
| getAmount-properties-4626.conf --rule getGhoAmountForBuyAsset_correctness | ✅ | 2 | Link |
| getAmount-properties-4626.conf --rule getAssetAmountForSellAsset_optimality getAssetAmountForBuyAsset_funcProperty | ✅ | 3 | Link |
| finishedRules-4626.conf --rule giftingUnderlyingDoesntCreateExcessOrDearth | ✅ | 2 | Link |
| fees-buy-4626.conf | ✅ | 8 | Link |
| edSellFeeIsAtLeastAsRequired collectedBuyFeePlus2IsAtLeastAsRequired collectedBuyFeePlus1IsAtLeastAsRequired collectedBuyFeeIsAtLeastAsRequired sellingDoesntExceedExposureCap whoCanChangeAccruedFees whoCanChangeExposure | ✅ | 22 | Link |
| balances-sell-4626.conf --rule R4_buyGhoUpdatesGhoBalanceCorrectly R4a_buyGhoAmountGtGhoBalanceChange | ✅ | 3 | Link |
| balances-sell-4626.conf --rule R3a_sellAssetUpdatesAssetBalanceCorrectly | ✅ | 2 | Link |
| balances-sell-4626.conf --rule R1_getAssetAmountForSellAsset_arg_vs_return R1a_buyGhoUpdatesGhoBalanceCorrectly1 R2_getAssetAmountForSellAsset_sellAsset_eq | ✅ | 4 | Link |
| balances-buy-4626.conf | ✅ | 8 | Link |
miguelmtzinf
approved these changes
Sep 2, 2025
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Certora Run Started (Certora Prover Run)
Certora Run Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the logic to encode and hash signatures in the GSM to respect EIP712, and updated the related unit tests with the new foundry cheatcodes.