feat: Remove _allVaults field and related view functions

Author: donosonaumczuk

src/ATokenVaultFactory.sol

@@ -12,7 +12,7 @@ import {ProxyAdmin} from "@openzeppelin/proxy/transparent/ProxyAdmin.sol";
 
 /**
  * @title ATokenVaultImplDeploymentLib
- * @author Aave Protocol
+ * @author Aave Labs
  * @notice Library that handles the deployment of the ATokenVault implementation contract
  * @dev This library is a helper to avoid holding the ATokenVault bytecode in the factory contract avoiding exceeding
  *      the contract size limit.
@@ -33,7 +33,7 @@ library ATokenVaultImplDeploymentLib {
 
 /**
  * @title ATokenVaultFactory
- * @author Aave Protocol
+ * @author Aave Labs
  * @notice Factory contract for deploying ATokenVault instances
  */
 contract ATokenVaultFactory {
@@ -60,12 +60,9 @@ contract ATokenVaultFactory {
     );
 
     /*//////////////////////////////////////////////////////////////
-                            STATE VARIABLES
+                               CONSTANTS
     //////////////////////////////////////////////////////////////*/
 
-    /// @notice Array of all deployed vaults
-    address[] internal _allVaults;
-
     /// @notice Proxy admin address for all deployed vaults, with renounced ownership.
     /// @dev Future version will deploy a plain immutable vault without proxy.
     address internal immutable RENOUNCED_PROXY_ADMIN;
@@ -146,8 +143,6 @@ contract ATokenVaultFactory {
             params.initialLockDeposit
         );
 
-        _allVaults.push(vault);
-
         emit VaultDeployed(
             vault,
             implementation,
@@ -156,40 +151,4 @@ contract ATokenVaultFactory {
             params
         );
     }
-
-    /*//////////////////////////////////////////////////////////////
-                              VIEW FUNCTIONS
-    //////////////////////////////////////////////////////////////*/
-
-    /**
-     * @notice Get the total number of deployed vaults
-     * @return The total number of vaults
-     */
-    function getAllVaultsLength() external view returns (uint256) {
-        return _allVaults.length;
-    }
-
-    /**
-     * @notice Get all deployed vaults
-     * @return Array of all vault addresses
-     */
-    function getAllVaults() external view returns (address[] memory) {
-        return _allVaults;
-    }
-
-    /**
-     * @notice Get vault deployment info
-     * @param vaultIndex The index of the vault in allVaults array
-     * @return vault The vault address
-     * @return underlying The underlying asset
-     */
-    function getVaultInfo(uint256 vaultIndex) external view returns (
-        address vault,
-        address underlying
-    ) {
-        require(vaultIndex < _allVaults.length, "INVALID_VAULT_INDEX");
-        vault = _allVaults[vaultIndex];
-        ATokenVault vaultContract = ATokenVault(vault);
-        underlying = address(vaultContract.UNDERLYING());
-    }
 }

test/ATokenVaultFactory.t.sol

@@ -159,11 +159,6 @@ contract ATokenVaultFactoryTest is Test {
         address vault2 = factory.deployVault(params2);
         vm.stopPrank();
 
-        assertEq(factory.getAllVaultsLength(), 2);
-        address[] memory allVaults = factory.getAllVaults();
-        assertEq(allVaults[0], vault1);
-        assertEq(allVaults[1], vault2);
-
         assertTrue(vault1 != vault2);
 
         ATokenVault vault1Contract = ATokenVault(vault1);
@@ -544,93 +539,6 @@ contract ATokenVaultFactoryTest is Test {
         assertEq(value, bytes32(uint256(uint160(proxyAdmin))));
     }
 
-    /*//////////////////////////////////////////////////////////////
-                            VIEW FUNCTION TESTS
-    //////////////////////////////////////////////////////////////*/
-
-    function testGetVaultInfo() public {
-        uint256 initialDeposit = 1000 * 1e18;
-        deal(address(dai), ALICE, initialDeposit);
-
-        vm.startPrank(ALICE);
-        dai.approve(address(factory), initialDeposit);
-
-        ATokenVaultFactory.VaultParams memory params = ATokenVaultFactory.VaultParams({
-            underlying: address(dai),
-            referralCode: 0,
-            poolAddressesProvider: IPoolAddressesProvider(address(poolAddrProvider)),
-            owner: ALICE,
-            initialFee: 0,
-            shareName: "Test Vault",
-            shareSymbol: "tVault",
-            initialLockDeposit: initialDeposit
-        });
-
-        address vault = factory.deployVault(params);
-        vm.stopPrank();
-
-        (address vaultAddr, address underlying) = factory.getVaultInfo(0);
-        assertEq(vaultAddr, vault);
-        assertEq(underlying, address(dai));
-    }
-
-    function testGetVaultInfoInvalidIndexReverts() public {
-        vm.expectRevert("INVALID_VAULT_INDEX");
-        factory.getVaultInfo(0);
-    }
-
-    function testGetVaultInfoMultipleVaults() public {
-        uint256 initialDeposit = 1000 * 1e18;
-
-        deal(address(dai), ALICE, initialDeposit * 2);
-        vm.startPrank(ALICE);
-        dai.approve(address(factory), initialDeposit * 2);
-
-        ATokenVaultFactory.VaultParams memory params1 = ATokenVaultFactory.VaultParams({
-            underlying: address(dai),
-            referralCode: 0,
-            poolAddressesProvider: IPoolAddressesProvider(address(poolAddrProvider)),
-            owner: ALICE,
-            initialFee: 0,
-            shareName: "First Vault",
-            shareSymbol: "FV",
-            initialLockDeposit: initialDeposit
-        });
-
-        address vault1 = factory.deployVault(params1);
-
-        vm.roll(block.number + 1);
-        vm.warp(block.timestamp + 1);
-
-        ATokenVaultFactory.VaultParams memory params2 = ATokenVaultFactory.VaultParams({
-            underlying: address(dai),
-            referralCode: 0,
-            poolAddressesProvider: IPoolAddressesProvider(address(poolAddrProvider)),
-            owner: ALICE,
-            initialFee: 0,
-            shareName: "Second Vault",
-            shareSymbol: "SV",
-            initialLockDeposit: initialDeposit
-        });
-
-        address vault2 = factory.deployVault(params2);
-        vm.stopPrank();
-
-        (address vaultAddr1, address underlying1) = factory.getVaultInfo(0);
-        (address vaultAddr2, address underlying2) = factory.getVaultInfo(1);
-
-        assertEq(vaultAddr1, vault1);
-        assertEq(underlying1, address(dai));
-        assertEq(vaultAddr2, vault2);
-        assertEq(underlying2, address(dai));
-    }
-
-    function testGetAllVaultsEmpty() public {
-        address[] memory vaults = factory.getAllVaults();
-        assertEq(vaults.length, 0);
-        assertEq(factory.getAllVaultsLength(), 0);
-    }
-
     /*//////////////////////////////////////////////////////////////
                             INTEGRATION TESTS
     //////////////////////////////////////////////////////////////*/
@@ -713,7 +621,6 @@ contract ATokenVaultFactoryTest is Test {
         vm.stopPrank();
 
         assertTrue(daiVault != usdcVault);
-        assertEq(factory.getAllVaultsLength(), 2);
     }
 
     function testDeploymentCounterIncreases() public {
@@ -751,7 +658,6 @@ contract ATokenVaultFactoryTest is Test {
         assertTrue(vault1 != vault2);
         assertTrue(vault2 != vault3);
         assertTrue(vault1 != vault3);
-        assertEq(factory.getAllVaultsLength(), 3);
     }
 
     function testDeployVaultEdgeCaseMinimalDeposit() public {