Skip to content

feat: Return addresses and amounts of claimed rewards #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: Return addresses and amounts of claimed rewards #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ATokenVault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ contract ATokenVault is ERC4626Upgradeable, OwnableUpgradeable, EIP712Upgradeabl
}

/// @inheritdoc IATokenVault
function claimRewards(address to) public override onlyOwner {
function claimRewards(address to) public override onlyOwner returns (address[] memory, uint256[] memory) {
require(to != address(0), "CANNOT_CLAIM_TO_ZERO_ADDRESS");

address[] memory assets = new address[](1);
Expand All @@ -441,6 +441,8 @@ contract ATokenVault is ERC4626Upgradeable, OwnableUpgradeable, EIP712Upgradeabl
).claimAllRewards(assets, to);

emit RewardsClaimed(to, rewardsList, claimedAmounts);

return (rewardsList, claimedAmounts);
}

/// @inheritdoc IATokenVault
Expand Down
4 changes: 3 additions & 1 deletion src/interfaces/IATokenVault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,10 @@ interface IATokenVault is IERC4626Upgradeable {
* @notice Claims any additional Aave rewards earned from vault deposits.
* @dev Only callable by the owner
* @param to The address to receive any rewards tokens
* @return The list of addresses of the rewards that have been claimed
* @return The list of amounts of rewards that have been claimed
*/
function claimRewards(address to) external;
function claimRewards(address to) external returns (address[] memory, uint256[] memory);

/**
* @notice Rescue any tokens other than the vault's aToken which may have accidentally been transferred to this
Expand Down
Loading