Skip to content

Conversation

@absis
Copy link

@absis absis commented Sep 17, 2025

The dependency review action scans your pull requests for dependency changes and raises an error if any new dependencies have known vulnerabilities. Once installed, if the workflow run is marked as required, pull requests introducing known vulnerable packages will be blocked from merging.

@linear
Copy link

linear bot commented Sep 17, 2025

Copy link

@alexmance alexmance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

🌈 Test Results
Compiling 107 files with Solc 0.8.30
installing solc version "0.8.30"
Successfully installed solc 0.8.30
Solc 0.8.30 finished in 1.23s
Compiler run successful!

Ran 7 tests for test/Lido_GhoDirectMinter.t.sol:Lido_GHODirectMinter_Test
[PASS] test_mintAndSupply_council(uint256) (runs: 256, μ: 246799, ~: 246203)
[PASS] test_mintAndSupply_owner(uint256) (runs: 256, μ: 244485, ~: 243850)
[PASS] test_mintAndSupply_rando() (gas: 19321)
[PASS] test_transferExcessToTreasury() (gas: 913203)
Logs:
  Bound result 1000000000000000000000

[PASS] test_withdrawAndBurn_council(uint256,uint256) (runs: 256, μ: 321977, ~: 322489)
[PASS] test_withdrawAndBurn_owner(uint256,uint256) (runs: 256, μ: 317327, ~: 318182)
[PASS] test_withdrawAndBurn_rando() (gas: 19232)
Suite result: ok. 7 passed; 0 failed; 0 skipped; finished in 26.41s (5.77s CPU time)

Ran 1 test suite in 26.42s (26.41s CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests)

@github-actions
Copy link

♻️ Forge Gas Snapshots

Seems like you are not measuring gas of any operations yet. 🤔
Consider adding some snapshot tests to measure regressions & improvements.

@github-actions
Copy link

🔮 Coverage report
File Line Coverage Function Coverage Branch Coverage
src/GhoDirectMinter.sol ${\color{green}100\%}$
$26 / 26$
${\color{green}100\%}$
$5 / 5$
${\color{red}50\%}$
$1 / 2$
src/proposals/LidoGHOListing.sol ${\color{green}100\%}$
$9 / 9$
${\color{green}100\%}$
$2 / 2$
${\color{green}100\%}$
$0 / 0$

@absis absis merged commit cff9c53 into main Sep 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants