feat: init templates #1
Conversation
templates/example-react/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@aave/client": "file:../../packages/client", | ||
| "@aave/env": "file:../../packages/env", |
There was a problem hiding this comment.
No need to import the internal packages either. All needed interfaces are re-exported from @aave/client and @aave/react respectively.
| "@aave/env": "file:../../packages/env", |
templates/example-react/package.json
Outdated
| "dependencies": { | ||
| "@aave/client": "file:../../packages/client", | ||
| "@aave/env": "file:../../packages/env", | ||
| "@aave/react": "file:../../packages/react", |
There was a problem hiding this comment.
I would start with:
| "@aave/react": "file:../../packages/react", | |
| "@aave/react": "workspace:*", |
for now that we are experimenting and we don't have published packages yet. Maybe over time we can change this to latest and make them runnable from stackblitz (but requires for us to have published the packages on npm).
templates/example-react/package.json
Outdated
| "@aave/env": "file:../../packages/env", | ||
| "@aave/react": "file:../../packages/react", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1" |
There was a problem hiding this comment.
should we try React 19?
There was a problem hiding this comment.
is 'create-app' name intentional or comes from Lens repo?
There was a problem hiding this comment.
i just added it as the first pass bare bones one
cesarenaldi
left a comment
cesarenaldi
left a comment
There was a problem hiding this comment.
Remember to add examples folder to the pnpm-workspace.yaml:
packages:
- 'packages/*'
- 'examples/*'
Once examples become stable and we can transition them to use @aave/react@latest (when packages are published) so that people can see them working with a click on stackblitz, we can revisit this configuration.
Co-authored-by: Cesare Naldi <[email protected]>
No description provided.