Skip to content

fix: supply example dropdown #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cesarenaldi merged 2 commits into from
Jul 22, 2025
Merged

fix: supply example dropdown #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e64823
fix: supply example dropdown
cesarenaldi Jul 22, 2025
fc9ef93
Merge branch 'main' into fix/supply-example
cesarenaldi Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/supply/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ export function App() {
const [market, setMarket] = useState<Market | null>(null);
const [reserve, setReserve] = useState<Reserve | null>(null);

const handleMarketSelect = (market: Market) => {
const handleMarketSelect = (market: Market | null) => {
setMarket(market);
setReserve(market.supplyReserves[0]);
setReserve(market?.supplyReserves[0] ?? null);
};

return (
Expand Down
15 changes: 4 additions & 11 deletions examples/supply/src/MarketSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { type ChainId, type Market, useAaveMarkets } from '@aave/react';
import { useEffect } from 'react';

interface MarketSelectorProps {
chainId: ChainId;
onChange: (market: Market) => void;
onChange: (market: Market | null) => void;
}

export function MarketSelector({
Expand All @@ -15,19 +14,12 @@ export function MarketSelector({
suspense: true,
});

useEffect(() => {
if (markets.length > 0) {
onMarketSelect(markets[0]);
}
}, [markets, onMarketSelect]);

const handleChange = (event: React.ChangeEvent<HTMLSelectElement>) => {
const selectedMarket = markets.find(
(market) => market.address === event.target.value,
);
if (selectedMarket) {
onMarketSelect(selectedMarket);
}

onMarketSelect(selectedMarket ?? null);
};

if (markets.length === 0) {
Expand All @@ -42,6 +34,7 @@ export function MarketSelector({
disabled={markets.length === 1}
style={{ padding: '8px', width: '100%' }}
>
<option value=''>Select a market</option>
{markets.map((market) => (
<option key={market.address} value={market.address}>
{market.name} - ${market.totalMarketSize}
Expand Down