test: reserve, borrowAPY, supplyAP #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarenaldi
reviewed
Jul 23, 2025
Contributor
There was a problem hiding this comment.
Given an Aave Market reserve
When fetching the reserve data
Then it should return the expected reserve details
When fetching supply APY history for it
Then it should return a time series for the specified time window
When fetching borrow APY history for it
Then it should return a time series for the specified time window
cesarenaldi
reviewed
Jul 23, 2025
Comment on lines
52
to
57
| expect.arrayContaining([ | ||
| expect.objectContaining({ | ||
| avgRate: expect.any(Object), | ||
| date: expect.any(String), | ||
| }), | ||
| ]), |
Contributor
There was a problem hiding this comment.
result.value.map(() => expect.objectContaining({
avgRate: {
// TODO try to match a reasonable BigDecimal precision
},
date: expect.toBeBetween(startDate, endDate)
}))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.