feat: graphql queries, actions and react hooks for borrow and supply apy #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaquinBattilana
force-pushed
the
feat/rates-sampling
branch
from
8e58afe to
4176f7e
Compare
cesarenaldi
reviewed
Jul 17, 2025
packages/client/src/actions/rates.ts
Outdated
| market: EvmAddress; | ||
| }; | ||
|
|
||
| export function supplyAPRHistory( |
Contributor
There was a problem hiding this comment.
Suggested change
| export function supplyAPRHistory( | |
| export function supplyAPYHistory( |
packages/client/src/actions/rates.ts
Outdated
| market: EvmAddress; | ||
| }; | ||
|
|
||
| export function borrowAPRHistory( |
Contributor
There was a problem hiding this comment.
Suggested change
| export function borrowAPRHistory( | |
| export function borrowAPYHistory( |
packages/react/src/rates.ts
Outdated
Comment on lines
53
to
56
| chainId, | ||
| underlyingToken, | ||
| window, | ||
| market, |
Contributor
There was a problem hiding this comment.
Unless we have a specific need (e.g., default one of these) I suggest to:
Suggested change
| chainId, | |
| underlyingToken, | |
| window, | |
| market, | |
| ...request |
so that supporting new fields is just matter of updating the schema.graphql and generating the graphql-end.d.ts.
packages/react/src/rates.ts
Outdated
Comment on lines
104
to
107
| chainId, | ||
| underlyingToken, | ||
| window, | ||
| market, |
Contributor
There was a problem hiding this comment.
Suggested change
| chainId, | |
| underlyingToken, | |
| window, | |
| market, | |
| ...request |
same here
packages/react/src/rates.ts
Outdated
| * ```tsx | ||
| * const { data } = useAaveMarkets({ | ||
| * chainIds: [chainId(1), chainId(8453)], | ||
| * user: evmAddress('0x742d35cc...'), |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| * user: evmAddress('0x742d35cc...'), | |
| * user: evmAddress('0x742d35cc…'), |
packages/react/src/rates.ts
Outdated
| * ```tsx | ||
| * const { data, loading } = useAaveMarkets({ | ||
| * chainIds: [chainId(1), chainId(8453)], | ||
| * user: evmAddress('0x742d35cc...'), |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| * user: evmAddress('0x742d35cc...'), | |
| * user: evmAddress('0x742d35cc…'), |
packages/client/src/actions/rates.ts
Outdated
Contributor
There was a problem hiding this comment.
Like discussed on Slack, we can colocate this within the reserve.ts (both at react and client packages).
JoaquinBattilana
changed the title
cesarenaldi
approved these changes
Jul 18, 2025
cesarenaldi
added a commit
that referenced
this pull request
Sep 2, 2025
…-setup chore: attempt to publish canary builds to GitHUb Registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.