Skip to content

feat: added override to proposal #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: added override to proposal #565

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fead1e9
feat: added override to proposal
JoaquinBattilana Dec 26, 2023
aea144d
feat: lint fix
JoaquinBattilana Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/contract-helpers/src/governance-contract/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { providers } from 'ethers';
import { CallOverrides, providers } from 'ethers';
import { formatEther } from 'ethers/lib/utils';
import BaseService from '../commons/BaseService';
import {
Expand Down Expand Up @@ -149,7 +149,10 @@ export class AaveGovernanceService
@GovHelperValidator
public async getProposal(
@is0OrPositiveAmount('proposalId')
{ proposalId }: GovGetProposalType,
{
proposalId,
overrides,
}: GovGetProposalType & { overrides?: CallOverrides },
) {
const helper: IGovernanceV2Helper = IGovernanceV2Helper__factory.connect(
this.aaveGovernanceV2HelperAddress,
Expand All @@ -158,6 +161,7 @@ export class AaveGovernanceService
const result = await helper.getProposal(
proposalId,
this.aaveGovernanceV2Address,
overrides,
);

return humanizeProposal(result);
Expand Down