feat: added scripts, more funcs, improvements, ts-documentation #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
2 times, most recently
from
28fd527 to
a416d20
Compare
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
from
a416d20 to
d4d1ab8
Compare
mpsc0x
changed the title
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
22 times, most recently
from
9202f32 to
c1e02be
Compare
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
3 times, most recently
from
b82458f to
2c942ba
Compare
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
2 times, most recently
from
19694f7 to
31f2a61
Compare
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
2 times, most recently
from
d4dc9fd to
74312cf
Compare
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
from
74312cf to
025f6ab
Compare
foodaka
reviewed
Mar 13, 2025
Comment on lines
+61
to
+67
| // FIXME | ||
| // public async configureAssets(config: Array<RewardsConfigInput>): Promise<CommittedTransactionResponse> { | ||
| // return this.sendTxAndAwaitResponse( | ||
| // this.peripheryContract.ConfigureAssets, | ||
| // [MoveVector.], | ||
| // ); | ||
| // } |
foodaka
reviewed
Mar 13, 2025
Comment on lines
+113
to
+121
| // FIXME | ||
| // public async configureAssets( | ||
| // config: Array<RewardsConfigInput>, | ||
| // ): Promise<CommittedTransactionResponse> { | ||
| // return this.sendTxAndAwaitResponse(this.peripheryContract.ConfigureAssets, [ | ||
| // config, | ||
| // ]); | ||
| // } | ||
|
|
foodaka
reviewed
Mar 13, 2025
| return AccountAddress.fromString(resp as string); | ||
| } | ||
|
|
||
| // FIX ME |
foodaka
reviewed
Mar 13, 2025
Comment on lines
+203
to
+229
| // public async lookupRewardsData(asset: AccountAddress, reward: AccountAddress, rewardsControllerAddress: AccountAddress): Promise<{assetData: AssetData, rewardData: RewardData}> { | ||
| // const resp = await this.callViewMethod( | ||
| // this.peripheryContract.LookupAssetData, | ||
| // [asset, reward, rewardsControllerAddress], | ||
| // ); | ||
| // const assetDataRaw = resp.at(0) as any; | ||
| // const rewardDataRaw = resp.at(1) as any; | ||
| // const assetData = { | ||
| // rewards: AccountAddress.fromString(assetDataRaw.rewards_admin), | ||
| // availableRewards: AccountAddress.fromString(assetDataRaw.incentives_controller), | ||
| // availableRewardsCount: AccountAddress.fromString(assetDataRaw.incentives_controller), | ||
| // decimals: assetDataRaw.decimals as number, | ||
| // } as AssetData; | ||
|
|
||
| // const rewardData = { | ||
| // index: AccountAddress.fromString(rewardDataRaw.index), | ||
| // emissionPerSecond: AccountAddress.fromString(rewardDataRaw.emission_per_second), | ||
| // distributionEnd: , | ||
| // lastUpdateTimestamp: , | ||
| // usersData: , | ||
| // } as RewardData; | ||
|
|
||
| // return { | ||
| // assetData, | ||
| // rewardData | ||
| // } | ||
| // } |
There was a problem hiding this comment.
do we want to remove this? or should we leave a note
Collaborator
Author
There was a problem hiding this comment.
this is still WIP will finish it soon
foodaka
reviewed
Mar 13, 2025
| * @param {string} user - The address of the user whose reserve data is being retrieved. | ||
| * @returns {Promise<UserReservesData>} A promise that resolves to an object containing the user's reserves data and eMode category ID. | ||
| */ | ||
| export class UiPoolDataProviderClient extends AptosContractWrapperBaseClass { |
There was a problem hiding this comment.
Would be great to document these methods @EmmanuellNorbertTulbure
Collaborator
Author
There was a problem hiding this comment.
Once I finish these, will add annotations!
foodaka
approved these changes
Mar 13, 2025
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
from
920a2b7 to
faa0eec
Compare
mpsc0x
force-pushed
the
fixes/evgeni/various
branch
from
faa0eec to
a2e051e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.