feat: collateral risk steward tests via configuration #2
Conversation
yan-man
changed the title
yan-man
changed the title
| super.test_updateEModeCategories_sameUpdate(); | ||
| } | ||
|
|
||
| /* ----------------------------- Collateral Tests ----------------------------- */ |
There was a problem hiding this comment.
where are the positive tests?
There was a problem hiding this comment.
separately, can you check is not a problem when using max relative change? i think the only place where we are using is on debtCeiling, but please confirm that.
main concern is that if value is 0, we may not be able to set to non-zero even with max_uint128 value as maxPercentChange
There was a problem hiding this comment.
for updateCollateralSide, confirmed - only place where max rel change is used is for debtCeiling. However, generally max relative change is also applied to supply/borrow caps as well (but shouldn't matter for collateral risk steward).
btw also for debt ceiling, we cannot configure a new newDebtCeiling > 0 when oldDebtCeiling == 0 and there are existing suppliers.
where are the positive tests?
positive tests are inherited from existing RiskSteward tests, do you think more are needed?
closes #1