fix: pr comments

Author: yan-man

scripts/misc/DeployHorizonPhaseTwoPayload.sol

@@ -17,8 +17,8 @@ contract DeployHorizonPhaseTwoPayload is Script {
       AaveV3EthereumHorizonCustom.AAVE_ORACLE,
       AaveV3EthereumHorizonCustom.REWARDS_CONTROLLER,
       AaveV3EthereumHorizonCustom.REVENUE_SPLITTER,
-      AaveV3EthereumHorizonCustom.ATOKEN_IMPLEMENTATION,
-      AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPLEMENTATION
+      AaveV3EthereumHorizonCustom.ATOKEN_IMPL,
+      AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPL
     );
 
     HorizonPhaseTwoListing horizonPhaseTwoListing = new HorizonPhaseTwoListing(

src/deployments/inputs/HorizonPhaseTwoListing.sol

@@ -63,8 +63,8 @@ contract HorizonPhaseTwoListing is AaveV3Payload {
         liqProtocolFee: 0
       }),
       IEngine.TokenImplementations({
-        aToken: AaveV3EthereumHorizonCustom.RWA_ATOKEN_IMPLEMENTATION,
-        vToken: AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPLEMENTATION
+        aToken: AaveV3EthereumHorizonCustom.RWA_ATOKEN_IMPL,
+        vToken: AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPL
       })
     );
 

tests/deployments/HorizonBase.t.sol

@@ -76,7 +76,7 @@ abstract contract HorizonBaseTest is Test {
     bool flashloanable;
     uint256 ltv;
     uint256 liquidationThreshold;
-    uint256 liquidationBonus;
+    uint256 liquidationBonus; // includes 100_00 base, so 103_00 = 3_00 bonus
     uint256 debtCeiling;
     uint256 liqProtocolFee;
     IDefaultInterestRateStrategyV2.InterestRateDataRay interestRateData;
@@ -98,9 +98,9 @@ abstract contract HorizonBaseTest is Test {
     defaultInterestRateStrategy = IDefaultInterestRateStrategyV2(
       AaveV3EthereumHorizonCustom.DEFAULT_INTEREST_RATE_STRATEGY
     );
-    aTokenImpl = AaveV3EthereumHorizonCustom.ATOKEN_IMPLEMENTATION;
-    variableDebtTokenImpl = AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPLEMENTATION;
-    rwaATokenImpl = AaveV3EthereumHorizonCustom.RWA_ATOKEN_IMPLEMENTATION;
+    aTokenImpl = AaveV3EthereumHorizonCustom.ATOKEN_IMPL;
+    variableDebtTokenImpl = AaveV3EthereumHorizonCustom.VARIABLE_DEBT_TOKEN_IMPL;
+    rwaATokenImpl = AaveV3EthereumHorizonCustom.RWA_ATOKEN_IMPL;
   }
 
   function test_listing(address token, TokenListingParams memory params) internal virtual {

tests/horizon/utils/AaveV3EthereumHorizonCustom.sol

@@ -12,10 +12,9 @@ library AaveV3EthereumHorizonCustom {
   address internal constant ACL_MANAGER = 0xEFD5df7b87d2dCe6DD454b4240b3e0A4db562321;
   address internal constant AAVE_PROTOCOL_DATA_PROVIDER =
     0x53519c32f73fE1797d10210c4950fFeBa3b21504;
-  address internal constant ATOKEN_IMPLEMENTATION = 0xB2668573828029917ffbD1e76270373511818498;
-  address internal constant RWA_ATOKEN_IMPLEMENTATION = 0x8CA2a49c7Df42E67F9A532F0d383D648fB7Fe4C9;
-  address internal constant VARIABLE_DEBT_TOKEN_IMPLEMENTATION =
-    0x15F03E5dE87c12cb2e2b8e5d6ECEf0a9E21ab269;
+  address internal constant ATOKEN_IMPL = 0xB2668573828029917ffbD1e76270373511818498;
+  address internal constant RWA_ATOKEN_IMPL = 0x8CA2a49c7Df42E67F9A532F0d383D648fB7Fe4C9;
+  address internal constant VARIABLE_DEBT_TOKEN_IMPL = 0x15F03E5dE87c12cb2e2b8e5d6ECEf0a9E21ab269;
   address internal constant DEFAULT_INTEREST_RATE_STRATEGY =
     0x87593272C06f4FC49EC2942eBda0972d2F1Ab521;
   address internal constant REVENUE_SPLITTER = 0x70CC725B8f05e0f230B05C4e91ABc651E121354f;