test: create scenarios for asset query #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarenaldi
reviewed
Dec 16, 2025
| id: expect.any(String), | ||
| token: expect.objectContaining({ | ||
| address: ETHEREUM_USDC_ADDRESS, | ||
| }), |
Collaborator
There was a problem hiding this comment.
should we add the chain in this assertion?
cesarenaldi
reviewed
Dec 16, 2025
| ); | ||
| }); | ||
|
|
||
| describe('When fetching the asset with a specific time window', () => { |
Collaborator
There was a problem hiding this comment.
It seems this test is adding little value for e2e spec perspective.
cesarenaldi
reviewed
Dec 16, 2025
| describe('Querying Asset Price History on Aave V4', () => { | ||
| describe('Given an asset/token available on the protocol', () => { | ||
| describe('When fetching the asset price history', () => { | ||
| it('Then it should return the asset price history', async () => { |
Collaborator
There was a problem hiding this comment.
This test seems to not add value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.