test: Vault spoke unit tests

tests/Base.t.sol

@@ -11,7 +11,10 @@ import {console2 as console} from 'forge-std/console2.sol';
 
 // dependencies
 import {AggregatorV3Interface} from 'src/dependencies/chainlink/AggregatorV3Interface.sol';
-import {TransparentUpgradeableProxy, ITransparentUpgradeableProxy} from 'src/dependencies/openzeppelin/TransparentUpgradeableProxy.sol';
+import {
+  TransparentUpgradeableProxy,
+  ITransparentUpgradeableProxy
+} from 'src/dependencies/openzeppelin/TransparentUpgradeableProxy.sol';
 import {ProxyAdmin} from 'src/dependencies/openzeppelin/ProxyAdmin.sol';
 import {IERC20Metadata} from 'src/dependencies/openzeppelin/IERC20Metadata.sol';
 import {SafeCast} from 'src/dependencies/openzeppelin/SafeCast.sol';
@@ -45,7 +48,11 @@ import {AccessManagerEnumerable} from 'src/access/AccessManagerEnumerable.sol';
 import {HubConfigurator, IHubConfigurator} from 'src/hub/HubConfigurator.sol';
 import {Hub, IHub, IHubBase} from 'src/hub/Hub.sol';
 import {SharesMath} from 'src/hub/libraries/SharesMath.sol';
-import {AssetInterestRateStrategy, IAssetInterestRateStrategy, IBasicInterestRateStrategy} from 'src/hub/AssetInterestRateStrategy.sol';
+import {
+  AssetInterestRateStrategy,
+  IAssetInterestRateStrategy,
+  IBasicInterestRateStrategy
+} from 'src/hub/AssetInterestRateStrategy.sol';
 
 // spoke
 import {Spoke, ISpoke, ISpokeBase} from 'src/spoke/Spoke.sol';

tests/unit/VaultSpoke/VaultSpoke.Base.t.sol

@@ -31,6 +31,22 @@ contract VaultSpokeBaseTest is Base {
       });
   }
 
+  function _depositData(
+    IVaultSpoke vault_,
+    address who,
+    uint256 amount,
+    uint256 deadline
+  ) internal view returns (EIP712Types.VaultDeposit memory) {
+    return
+      EIP712Types.VaultDeposit({
+        depositor: who,
+        assets: amount,
+        receiver: who,
+        nonce: vault_.nonces(who),
+        deadline: deadline
+      });
+  }
+
   function _mintData(
     IVaultSpoke vault,
     address who,
@@ -46,6 +62,22 @@ contract VaultSpokeBaseTest is Base {
       });
   }
 
+  function _mintData(
+    IVaultSpoke vault_,
+    address who,
+    uint256 shares,
+    uint256 deadline
+  ) internal view returns (EIP712Types.VaultMint memory) {
+    return
+      EIP712Types.VaultMint({
+        depositor: who,
+        shares: shares,
+        receiver: who,
+        nonce: vault_.nonces(who),
+        deadline: deadline
+      });
+  }
+
   function _withdrawData(
     IVaultSpoke vault,
     address who,
@@ -61,6 +93,22 @@ contract VaultSpokeBaseTest is Base {
       });
   }
 
+  function _withdrawData(
+    IVaultSpoke vault_,
+    address who,
+    uint256 assets,
+    uint256 deadline
+  ) internal view returns (EIP712Types.VaultWithdraw memory) {
+    return
+      EIP712Types.VaultWithdraw({
+        owner: who,
+        assets: assets,
+        receiver: who,
+        nonce: vault_.nonces(who),
+        deadline: deadline
+      });
+  }
+
   function _redeemData(
     IVaultSpoke vault,
     address who,
@@ -76,6 +124,22 @@ contract VaultSpokeBaseTest is Base {
       });
   }
 
+  function _redeemData(
+    IVaultSpoke vault_,
+    address who,
+    uint256 shares,
+    uint256 deadline
+  ) internal view returns (EIP712Types.VaultRedeem memory) {
+    return
+      EIP712Types.VaultRedeem({
+        owner: who,
+        shares: shares,
+        receiver: who,
+        nonce: vault_.nonces(who),
+        deadline: deadline
+      });
+  }
+
   function _permitData(
     IVaultSpoke vault,
     address who,
@@ -137,6 +201,15 @@ contract VaultSpokeBaseTest is Base {
       user: who
     });
   }
+
+  function _deposit(IVaultSpoke vault_, address user, uint256 amount) internal {
+    deal(address(tokenList.dai), user, amount);
+
+    vm.startPrank(user);
+    tokenList.dai.approve(address(vault_), amount);
+    vault_.deposit(amount, user);
+    vm.stopPrank();
+  }
 }
 
 contract VaultSpokeInitTest is VaultSpokeBaseTest {
@@ -156,6 +229,25 @@ contract VaultSpokeInitTest is VaultSpokeBaseTest {
     assertEq(instance.decimals(), hub1.getAsset(assetId).decimals);
   }
 
+  function test_deploy_reverts_InvalidHub() public {
+    address invalidHub = address(0);
+    vm.expectRevert();
+    new VaultSpokeInstance(invalidHub, daiAssetId);
+  }
+
+  /// @dev Cannot re-initialize the contract
+  function test_reinitialize_revertsWith_InvalidInitialization() public {
+    vm.expectRevert(Initializable.InvalidInitialization.selector);
+    VaultSpoke(address(daiVault)).initialize('new name', 'new symbol');
+  }
+
+  /// @dev Cannot directly initialize the implementation contract
+  function test_cannot_init_impl() public {
+    VaultSpokeInstance vaultImpl = new VaultSpokeInstance(address(hub1), daiAssetId);
+    vm.expectRevert(Initializable.InvalidInitialization.selector);
+    vaultImpl.initialize('impl name', 'impl symbol');
+  }
+
   function test_setUp() public {
     assertEq(daiVault.name(), SHARE_NAME);
     assertEq(daiVault.symbol(), SHARE_SYMBOL);

tests/unit/VaultSpoke/VaultSpoke.Permit.t.sol

@@ -2,6 +2,7 @@
 pragma solidity ^0.8.0;
 
 import 'tests/unit/VaultSpoke/VaultSpoke.Base.t.sol';
+import {IERC4626} from 'src/dependencies/openzeppelin/IERC4626.sol';
 
 contract VaultSpokePermitTest is VaultSpokeBaseTest {
   IVaultSpoke public vault;
@@ -133,4 +134,38 @@ contract VaultSpokePermitTest is VaultSpokeBaseTest {
     (, bytes32[] memory writeSlots) = vm.accesses(address(vault));
     assertEq(writeSlots.length, 0);
   }
+
+  function test_depositWithPermit(uint256 depositAmount) public {
+    depositAmount = bound(depositAmount, 1, MAX_SUPPLY_AMOUNT);
+    (address user, uint256 userPk) = makeAddrAndKey('user');
+
+    deal(address(tokenList.dai), user, depositAmount);
+
+    assertEq(tokenList.dai.balanceOf(user), depositAmount);
+    assertEq(tokenList.dai.balanceOf(address(daiVault)), 0);
+    assertEq(tokenList.dai.balanceOf(address(hub1)), 0);
+    assertEq(daiVault.balanceOf(user), 0);
+
+    EIP712Types.Permit memory params = EIP712Types.Permit({
+      owner: user,
+      spender: address(daiVault),
+      value: depositAmount,
+      deadline: vm.getBlockTimestamp() + 1,
+      nonce: tokenList.dai.nonces(user)
+    });
+    (uint8 v, bytes32 r, bytes32 s) = vm.sign(userPk, _getTypedDataHash(tokenList.dai, params));
+
+    vm.prank(user);
+    vm.expectEmit(address(daiVault));
+    emit IERC4626.Deposit(user, user, depositAmount, depositAmount);
+    uint256 shares = daiVault.depositWithPermit(depositAmount, user, params.deadline, v, r, s);
+
+    assertEq(tokenList.dai.balanceOf(user), 0);
+    assertEq(tokenList.dai.balanceOf(address(daiVault)), 0);
+    assertEq(daiVault.totalAssets(), depositAmount);
+    assertEq(daiVault.balanceOf(user), depositAmount);
+    assertEq(tokenList.dai.balanceOf(address(hub1)), depositAmount);
+
+    assertEq(hub1.getSpokeAddedShares(daiAssetId, address(daiVault)), shares);
+  }
 }