chore: restricted eliminate deficit #1067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avniculae
reviewed
Dec 17, 2025
| address spoke | ||
| ) external returns (uint256) { | ||
| ) external restricted returns (uint256) { | ||
| Asset storage asset = _assets[assetId]; |
Contributor
There was a problem hiding this comment.
check asset is registered
avniculae
reviewed
Dec 17, 2025
| ) external restricted returns (uint256) { | ||
| Asset storage asset = _assets[assetId]; | ||
| SpokeData storage callerSpoke = _spokes[assetId][msg.sender]; | ||
| SpokeData storage coveredSpoke = _spokes[assetId][spoke]; |
Contributor
There was a problem hiding this comment.
check coveredSpoke is registered
avniculae
reviewed
Dec 17, 2025
yan-man
reviewed
Dec 17, 2025
| bytes4[] memory selectors = new bytes4[](1); | ||
| selectors[0] = IHub.eliminateDeficit.selector; | ||
| manager.setTargetFunctionRole(address(targetHub), selectors, Roles.HUB_UMBRELLA_ROLE); | ||
| } |
Contributor
There was a problem hiding this comment.
can you put this into a helper func, will be easier to refactor later
yan-man
reviewed
Dec 17, 2025
| ); | ||
|
|
||
| vm.prank(ADMIN); | ||
| accessManager.grantRole(Roles.HUB_UMBRELLA_ROLE, address(spoke1), 0); |
Contributor
There was a problem hiding this comment.
can you put this into a helper func too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.