feat: Reentrancy locks in Spoke #1073
Open
+484
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avniculae
force-pushed
the
feat/reentrancy-locks
branch
from
0dcc11b to
d4f9ba8
Compare
yan-man
reviewed
Dec 18, 2025
| import {MockERC1271Wallet} from 'tests/mocks/MockERC1271Wallet.sol'; | ||
| import {MockSpokeInstance} from 'tests/mocks/MockSpokeInstance.sol'; | ||
| import {MockSkimSpoke} from 'tests/mocks/MockSkimSpoke.sol'; | ||
| import {MockReentrantHub} from 'tests/mocks/MockReentrantHub.sol'; |
Contributor
There was a problem hiding this comment.
more contracts into base :'(
avniculae
requested review from
CheyenneAtapour,
DhairyaSethi,
Kogaroshi,
miguelmtzinf and
yan-man
avniculae
force-pushed
the
feat/reentrancy-locks
branch
from
d4f9ba8 to
875b77c
Compare
yan-man
reviewed
Dec 20, 2025
| uint256 collateralReserveId = _daiReserveId(spoke); | ||
| uint256 debtReserveId = _wethReserveId(spoke); | ||
|
|
||
| // _updateTargetHealthFactor(spoke, 1.001e18); |
miguelmtzinf
reviewed
Jan 2, 2026
| ); | ||
| vm.expectRevert(ReentrancyGuardTransient.ReentrancyGuardReentrantCall.selector); | ||
| vm.prank(bob); | ||
| spoke1.supply(_daiReserveId(spoke1), amount, bob); |
Member
There was a problem hiding this comment.
let's use onBehalf so we make sure reentrancy lock is checked first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.