Skip to content

chore: reorder rp update on deficit #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhairyaSethi wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

chore: reorder rp update on deficit #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/spoke/Spoke.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,13 +390,12 @@ abstract contract Spoke is ISpoke, Multicall, NoncesKeyed, AccessManagedUpgradea
params
);

uint256 newRiskPremium = 0;
if (isUserInDeficit) {
_reportDeficit(user);
} else {
newRiskPremium = _calculateUserAccountData(user).riskPremium;
uint256 newRiskPremium = _calculateUserAccountData(user).riskPremium;
_notifyRiskPremiumUpdate(user, newRiskPremium);
}
_notifyRiskPremiumUpdate(user, newRiskPremium);
}

/// @inheritdoc ISpoke
Expand Down Expand Up @@ -862,6 +861,7 @@ abstract contract Spoke is ISpoke, Multicall, NoncesKeyed, AccessManagedUpgradea
/// @dev It clears the user position, setting drawn debt, premium debt, and risk premium to zero.
function _reportDeficit(address user) internal {
PositionStatus storage positionStatus = _positionStatus[user];
positionStatus.riskPremium = 0;

uint256 reserveId = _reserveCount;
while ((reserveId = positionStatus.nextBorrowing(reserveId)) != PositionStatusMap.NOT_FOUND) {
Expand All @@ -888,6 +888,7 @@ abstract contract Spoke is ISpoke, Multicall, NoncesKeyed, AccessManagedUpgradea

emit ReportDeficit(reserveId, user, deficitShares, premiumDelta);
}
emit UpdateUserRiskPremium(user, 0);
}

function _getReserve(uint256 reserveId) internal view returns (Reserve storage) {
Expand Down
Loading