Skip to content

fix: unit price feed safecast #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yan-man wants to merge 2 commits into
base: dev
Choose a base branch
from
+12 −1
Open

fix: unit price feed safecast #1088

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c8fee
fix: safecast on unit price feed
yan-man Jan 6, 2026
aebdb57
test: safecast overflow
yan-man Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/misc/UnitPriceFeed.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@
pragma solidity 0.8.28;

import {AggregatorV3Interface} from 'src/dependencies/chainlink/AggregatorV3Interface.sol';
import {SafeCast} from 'src/dependencies/openzeppelin/SafeCast.sol';

/// @title UnitPriceFeed contract
/// @author Aave Labs
/// @notice Price feed that returns the unit price (1), with decimals precision.
/// @dev This price feed can be set for reserves that use the base currency as collateral.
contract UnitPriceFeed is AggregatorV3Interface {
using SafeCast for uint256;

/// @inheritdoc AggregatorV3Interface
uint8 public immutable decimals;

Expand All @@ -23,7 +26,7 @@ contract UnitPriceFeed is AggregatorV3Interface {
constructor(uint8 decimals_, string memory description_) {
decimals = decimals_;
description = description_;
_units = int256(10 ** decimals_);
_units = (10 ** decimals_).toInt256();
Copy link
Member

@DhairyaSethi DhairyaSethi Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda unnecessary bc this is a one time fn and if any overflow the contract can be discarded. would be more in favour if this was fixing a run time unsafe cast

}

/// @inheritdoc AggregatorV3Interface
Expand Down
Loading