[WIP]: fix: Liquidity growth calculation in fees logic & fee cache in storage #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avniculae
commented
Oct 17, 2025
src/hub/Hub.sol
Outdated
| Asset storage asset = _assets[assetId]; | ||
| uint256 unrealized = spoke == asset.feeReceiver ? asset.unrealizedFeeShares() : 0; | ||
| return asset.toAddedAssetsDown(_spokes[assetId][spoke].addedShares + unrealized); | ||
| uint256 feeShares = spoke == asset.feeReceiver ? asset.feeShares : 0; |
Contributor
Author
There was a problem hiding this comment.
I think here we should also add the unrealized fee shares
avniculae
changed the title
Certora Run Started (Verified Rules)
Certora Run Summary
|
avniculae
force-pushed
the
fix/share-price-disjoint
branch
from
bb1d8b1 to
d42678e
Compare
Certora Run Started (Verified Rules)
Certora Run Summary
|
Contributor
Author
|
Closing in favour of #933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prover.certora.com/output/3973608/ec6321ee61e9427fa5d2d9271105e3aa/?anonymousKey=66a5b1e907623d1ef2b066525c9855748a1e432a