[WIP]: fix: Liquidity growth calculation in fees logic & fee cache in transient storage #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avniculae
commented
Oct 17, 2025
avniculae
commented
- https://prover.certora.com/output/3973608/d1918d257dee446590bfd764ecd4f651/?anonymousKey=a59f76058509f8901d57a8d94830bc2aa8472ee7
Certora Run Started (Verified Rules)
Certora Run Summary
|
avniculae
commented
Oct 17, 2025
|
|
||
| /// @notice Accrues interest and fees for the specified asset. | ||
| function accrue(IHub.Asset storage asset) internal { | ||
| if (asset.lastUpdateTimestamp == block.timestamp) { |
Contributor
Author
There was a problem hiding this comment.
add comment -- this cannot be removed now
avniculae
commented
Oct 17, 2025
| using TransientSlot for *; | ||
|
|
||
| /// bytes32(uint256(keccak256("FEE_AMOUNT")) - 1) | ||
| TransientSlot.Uint256Slot internal constant FEE_AMOUNT_SLOT = |
Contributor
Author
There was a problem hiding this comment.
pack fee amount and fee shares in the same slot
avniculae
commented
Oct 17, 2025
| // SPDX-License-Identifier: UNLICENSED | ||
| // Copyright (c) 2025 Aave Labs | ||
| pragma solidity ^0.8.20; | ||
| pragma solidity ^0.8.28; |
Contributor
Author
There was a problem hiding this comment.
undo this (this was done to make certora rule compile)
avniculae
commented
Oct 17, 2025
| uint256 unrealized = spoke == asset.feeReceiver ? asset.unrealizedFeeShares() : 0; | ||
| return asset.toAddedAssetsDown(_spokes[assetId][spoke].addedShares + unrealized); | ||
| uint256 feeShares = spoke == asset.feeReceiver | ||
| ? asset.getUnrealizedFeeShares(asset.getUnrealizedFeeAmount(asset.getDrawnIndex())) |
Contributor
Author
There was a problem hiding this comment.
if this is queried after accrue but before fee shares are minted (in the same block), this will be wrong. however, I don't think this scenario exists (need to double check). If such scenario does not exist, should we fix it (by looking at the transient storage as well) just to be safer, or leave as is?
avniculae
commented
Oct 17, 2025
| asset.liquidity += amount.toUint128(); | ||
|
|
||
| asset.updateDrawnRate(assetId); | ||
| asset.mintFeeShares(_spokes, assetId); |
Contributor
Author
There was a problem hiding this comment.
is there a way to ensure we always mint fee shares at the end of actions that accrue? current impl is a bit error-prone
yan-man
reviewed
Oct 17, 2025
| } | ||
|
|
||
| /// @notice Accrues interest and fees for the specified asset. | ||
| function accrue(IHub.Asset storage asset) internal { |
Contributor
There was a problem hiding this comment.
let's make sure to clearly document this and the need to couple this with the mintFeeShares
avniculae
changed the title
Contributor
Author
|
This was addressed in #933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.