USTB GSM Implementation #432

yan-man · 2024-10-15T13:44:30Z

USTB GSM Implementation

branched off of #421 (merge that first, or isolate USTB-specific changes)
closes #431

…enforce no remaining balance in converter

test: remaining gho balance

…ariables

…oBalance

…specific

height · 2024-10-15T13:44:33Z

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

test: init testing of rounding edge case

test: try to isolate rounding issues for USDC converter

yan-man added 30 commits August 30, 2024 18:20

feat: skeleton for GsmConverter buyAsset

ab52741

fix: resolve compilation issues

b102136

feat: initialize interface

dd74cc2

refactor: move files to separate directory

023a6b4

fix: resolve interface function visibility

750eb61

test: initialize constructor unit test

038e3be

test: testRevertConstructorZeroAddressParams;

c574b35

test: initialize BUIDL-specific test GSM

56ab408

test: add check on buyAsset for minAmount

5760379

test: happy path for converter buyAsset

bb08c59

test: events testing + happy path buyAsset

eb4a888

test: test revert cases

8ca6481

fix: resolve tests involving facilitator due to new one added

2942b36

fix: resolve fuzz test input with zero address

ebca6d7

feat: rescueTokens implementation + tests

cff5b1f

fix: convert to Ownable

4d2abe2

fix: validate calculated ghoAmount matches ghoSold, reset approvals, …

2faf8a6

…enforce no remaining balance in converter

test: create mockGSM to test unmatching gho amount case

bc05a7d

refactor: methods re-order

0c1beb2

refactor: rename mock

117eda8

test: remaining gho balance

test: test coverage for remaining token balances

4f4603c

feat: init buyAssetWithSig

1dbff49

test: happy path test for buyAssetWithSig

bce34e7

test: simplify testBuyAssetWithSig, add testBuyAssetWithSigExactDeadline

62657ee

test: add testRevertBuyAssetWithSigExpiredSignature

522ada9

test: add testRevertBuyAssetWithSigInvalidSignature

b60751d

test: add testRevertBuyAssetWithSigInvalidAmount

6d90a66

test: refer to proper value for BUIDL gsm exposure

ea90912

test: resolve test assertion on remaining gsm gho balance

c9140c5

test: clean up assertion failure messages, reference different test v…

14fc942

…ariables

yan-man added 19 commits September 11, 2024 09:38

test: clean up var references and add testFuzzSellAssetMaxAmount

fdc083e

test: clean up var reference

df84a21

test: add fuzz tests, testRevertSellAssetWithSigInvalidNonce

91fb7b9

test: add testRevertBuyAssetWithSigInvalidNonce

655b0b0

test: remove mock test files from coverage

d0f89f2

fix: remove need to upgrade gsm to trigger error

8a47c39

Merge branch 'main' into feat/gsm-buidl

6e208a2

feat: init GsmConverter overview doc

3d7cbb0

test: reduce unneeded mock code for MockGsmFailedSellAssetRemainingGh…

feeda78

…oBalance

refactor: rename subscription event

53dc395

test: resolve tests from event change, rename mock files to be BUIDL-…

b48a0be

…specific

Merge branch 'main' into feat/gsm-buidl

ae2dec4

refactor: rename issuance to subscription

72ee91d

test: add mock USTB subscription/redemption contract

9a686d3

feat: add todo notes on subscription fees

16a5d59

fix: account for subscription fee, resolve tests, param names

c943e73

test: end prank

0201eea

Merge branch 'feat/gsm-buidl' into feat/gsm-ustb

a32f7ee

test: update mock comments

a7a828f

yan-man added 10 commits October 15, 2024 16:10

feat: skeleton for USTB GSM converter based on buidl gsm converter

ae10ad6

fix: add some comments for later fixes

e5545c8

test: update mock with preview methods

c95eb96

fix: clean up mock price

376863c

fix: clean up logic for USTB gsm converter and add interface

68baa18

fix: clarify comments

655dfaa

fix: resolve compilation of USTB sub/red

40fc06e

test: init testing of rounding edge case

forge install: ustb

d85915b

feat: integrate USTB contracts

9209e59

chore: clean up dependencies, remove USTB

8272ca6

test: try to isolate rounding issues for USDC converter

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

USTB GSM Implementation #432

USTB GSM Implementation #432

Uh oh!

yan-man commented Oct 15, 2024 •

edited

Loading

Uh oh!

height bot commented Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

USTB GSM Implementation #432

Are you sure you want to change the base?

USTB GSM Implementation #432

Uh oh!

Conversation

yan-man commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

height bot commented Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yan-man commented Oct 15, 2024 •

edited

Loading