Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve css on view transactions button [skip cypress] #2368

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

foodaka
Copy link
Collaborator

@foodaka foodaka commented Feb 18, 2025

General Changes

  • Adds more consistent layout for view transactions button which looks bugged on dapp browsers
    Screenshot 2025-02-18 at 12 34 28

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:36am
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:36am

Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 865.09 KB (🟡 +6.42 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 48.2 KB (🟢 -4.47 KB) 913.29 KB
/404 2.47 KB (🟢 -4.93 KB) 867.56 KB
/500 2.91 KB (🟢 -4.91 KB) 867.99 KB
/bridge 35.72 KB (🟢 -5.07 KB) 900.8 KB
/faucet 14.66 KB (🟢 -5.17 KB) 879.75 KB
/governance 82.33 KB (🟢 -5.35 KB) 947.42 KB
/governance/ipfs-preview 99.84 KB (🟢 -5.32 KB) 964.93 KB
/governance/v3/proposal 125.68 KB (🟢 -5.35 KB) 990.76 KB
/history 22.88 KB (🟢 -5.6 KB) 887.97 KB
/markets 28.16 KB (🟢 -5.28 KB) 893.24 KB
/reserve-overview 20.75 KB (🟢 -5.6 KB) 885.84 KB
/staking 33.29 KB (🟢 -5.02 KB) 898.38 KB
/v3-migration 32.12 KB (🟢 -4.52 KB) 897.21 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@foodaka foodaka changed the title chore: improve css on view transactions button chore: improve css on view transactions button [skip cypress] Feb 20, 2025
@foodaka foodaka merged commit f0e8ef6 into main Feb 20, 2025
22 of 23 checks passed
@foodaka foodaka deleted the fix/view-transactions-layout branch February 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants