Skip to content

Conversation

@MartinGbz
Copy link
Contributor

General Changes

The Merkl API have some issue regarding the info it provides. A fix was needed on order to display the incentives.

Fix:

  • eligible token address
  • reward token address

Now the incentives are now display.

Note: We're currently talking with Merkl to improve their API (because it's not yet fully optimal)

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@vercel
Copy link

vercel bot commented Jul 16, 2025

@MartinGbz is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/16325653255'

@foodaka foodaka merged commit 500a69f into aave:main Jul 16, 2025
9 of 10 checks passed
const apr = opportunity.apr / 100;

const rewardToken = opportunity.tokens[opportunity.tokens.length - 1];
const rewardToken = opportunity.rewardsRecord.breakdowns[0].token;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can breakdowns be empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants