Skip to content

Conversation

@AGMASO
Copy link
Collaborator

@AGMASO AGMASO commented Oct 8, 2025

General Changes

  • apply valueToBigNumber() instead parseUnits() for approvedAmount values retrieve from the user, to avoid app crash.

Developer Notes

Bug Explanation

A user account tried to repay their debt in USDT. The app was crashing when they attempted to input a value to repay in the modal.

The following log was retrieved:
Screenshot 2025-10-08 at 18 20 13

Our useApprovalTx hook was not expecting “infinite approvals” and was trying to use parseUnits() on a huge number in scientific notation, which caused the crash. We’ve now replaced it with valueToBigNumber() to properly handle numbers in scientific notation and convert them to plain numbers without decimals.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@vercel
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
interface Ready Ready Preview Comment Oct 8, 2025 4:21pm

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@AGMASO AGMASO merged commit b9a8d89 into main Oct 15, 2025
19 of 21 checks passed
@AGMASO AGMASO deleted the fix/bug-on-repay branch October 15, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants