feat: added hardcoded incentives for PYUSD #2706
Conversation
AGMASO
requested review from
JoaquinBattilana,
Copilot,
foodaka,
grothem and
mgrabina
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds hardcoded incentive data for PYUSD (PayPal USD) stablecoin in the Aave protocol. The change enables display of specific incentive information for PYUSD suppliers without relying on external API data.
- Adds hardcoded incentive configuration for PYUSD A_TOKEN
- Implements conditional logic to return hardcoded data when PYUSD is the rewarded asset
- Includes custom messaging about PYUSD program requirements
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const protocolIncentivesAPR = protocolIncentives.reduce((sum, inc) => { | ||
| return sum + (inc.incentiveAPR === 'Infinity' ? 0 : +inc.incentiveAPR); | ||
| }, 0); | ||
| const merklIncentivesAPY = convertAprToApy(0.1); |
There was a problem hiding this comment.
The hardcoded value 0.1 (10%) should be extracted as a named constant to improve maintainability and make the source of this value clear.
| breakdown: { | ||
| protocolAPY: 0, | ||
| protocolIncentivesAPR: 0, | ||
| merklIncentivesAPR: 0, | ||
| totalAPY: 0, | ||
| isBorrow: false, | ||
| breakdown: { | ||
| protocol: 0, | ||
| protocolIncentives: 0, | ||
| merklIncentives: 0, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
The breakdown object in the hardcoded incentives appears to be duplicated and potentially inconsistent with the dynamically calculated breakdown returned later. Consider removing the hardcoded breakdown since it's recalculated anyway.
| breakdown: { | |
| protocolAPY: 0, | |
| protocolIncentivesAPR: 0, | |
| merklIncentivesAPR: 0, | |
| totalAPY: 0, | |
| isBorrow: false, | |
| breakdown: { | |
| protocol: 0, | |
| protocolIncentives: 0, | |
| merklIncentives: 0, | |
| }, | |
| }, |
| } as MerklIncentivesBreakdown, | ||
| } as ExtendedReserveIncentiveResponse; |
There was a problem hiding this comment.
Using type assertions with 'as' can bypass TypeScript's type checking. Consider ensuring the object structure matches the expected types or use proper type guards to validate the structure.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
General Changes
Developer Notes
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files