Skip to content

feat: enable geo #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foodaka merged 3 commits into from
Dec 30, 2025
Merged

feat: enable geo #2824

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73184d4
feat: enable geo
foodaka Dec 30, 2025
cadb2a6
fix: pr comment
foodaka Dec 30, 2025
513a435
fix: opt out
foodaka Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/store/analyticsSlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const createAnalyticsSlice: StateCreator<
// serverZone: 'EU',
autocapture: true, // disable if we don't want to capture every click and page view on the site
trackingOptions: {
ipAddress: false,
ipAddress: true,
language: false,
platform: true,
},
Expand All @@ -111,7 +111,7 @@ export const createAnalyticsSlice: StateCreator<
// serverZone: 'EU',
autocapture: false,
trackingOptions: {
ipAddress: false,
ipAddress: true,
language: false,
platform: false,
},
Expand Down Expand Up @@ -151,7 +151,7 @@ export const createAnalyticsSlice: StateCreator<
init(AMPLITUDE_API_KEY, {
autocapture: false,
trackingOptions: {
ipAddress: false,
ipAddress: true,
Copy link
Contributor

@mgrabina mgrabina Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth it to double check with legal if we can track IPs while opted out/not opted in yet

Copy link
Collaborator Author

@foodaka foodaka Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we should not, ive removed

language: false,
Comment on lines 153 to 155
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Respect opt-out by avoiding IP capture on decline event

In rejectAnalytics, the minimal Amplitude init used solely to send analytics_consent_declined now sets trackingOptions.ipAddress to true. The function then temporarily disables opt-out and dispatches the decline event, so even users who explicitly refuse analytics will have their IP/geo data collected for that event. Previously IP collection was disabled in this path, so this is a privacy regression for opt-out users; the rejection flow should not send PII like IP addresses.

Useful? React with 👍 / 👎.

platform: false,
},
Expand Down
Loading