Replace android.preference.PreferenceManager with AndroidX - #22
Merged
Conversation
Drop-in import swap across 14 files. The AndroidX PreferenceManager (already a project dependency at 1.2.1) provides the same getDefaultSharedPreferences() API with zero behavioral change. Closes #21
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward import-only swap and a repo-wide search confirms no remaining android.preference.PreferenceManager references.
Pull request overview
This PR completes a low-risk AndroidX migration step by replacing deprecated android.preference.PreferenceManager imports with androidx.preference.PreferenceManager across the spa2 app, reducing deprecation warnings without changing runtime behavior (same getDefaultSharedPreferences(Context) API).
Changes:
- Swapped 14 import statements from framework
PreferenceManagerto AndroidXPreferenceManager. - Verified repository-wide removal of
android.preference.PreferenceManagerreferences.
File summaries
| File | Description |
|---|---|
| spa2/src/main/java/cz/absolutno/sifry/braille/BrailleDFragment.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/common/activity/BottomBarActivity.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/common/activity/SettingsActivity.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/common/alphabet/Alphabet.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/common/decoder/StatefulDecoder.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/frekvence/EmpirSubstFragment.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/frekvence/FrekvRFragment.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/kalendar/KalendarActivity.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/mainscreen/MainActivity.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/regexp/RegExpDFragment.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/tabulky/AidView.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/transpozice/TransView.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/vlajky/VlajkyDFragment.java | Import swap to AndroidX PreferenceManager. |
| spa2/src/main/java/cz/absolutno/sifry/zapisnik/ZapisnikDFragment.java | Import swap to AndroidX PreferenceManager. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop-in import swap: replace all
android.preference.PreferenceManagerimports withandroidx.preference.PreferenceManageracross 14 files.The AndroidX
PreferenceManager(already a project dependency atandroidx.preference:preference:1.2.1) provides the samegetDefaultSharedPreferences(Context)API with zero behavioral change.What changed
14 single-line import replacements — no logic changes:
BrailleDFragment.javaBottomBarActivity.javaSettingsActivity.javaAlphabet.javaStatefulDecoder.javaEmpirSubstFragment.javaFrekvRFragment.javaKalendarActivity.javaMainActivity.javaRegExpDFragment.javaAidView.javaTransView.javaVlajkyDFragment.javaZapisnikDFragment.javaVerification
JAVA_HOME=/usr/lib/jvm/java-17-openjdk ./gradlew :spa2:assembleDebug— builds successfullyandroid.preference.PreferenceManagerimports remainCloses #21