Drop legacy-support-v4, replace Space with platform widget - #23
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Gradle wrapper scripts (gradlew/gradlew.bat) were modified in a way that is non-standard and likely breaks portability (especially Cygwin/MSYS/Windows), and the PR also introduces an unrelated settings plugin without justification.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Modernizes the Android module by removing the legacy-support-v4 dependency and switching calendar layouts from the legacy Space widget to the platform android.widget.Space.
Changes:
- Removed
androidx.legacy:legacy-support-v4:1.0.0fromspa2dependencies. - Replaced
androidx.legacy.widget.Spacewithandroid.widget.Spacein portrait/landscape calendar layouts. - Updated Gradle settings / wrapper scripts (adds toolchains resolver plugin; changes wrapper launch behavior).
File summaries
| File | Description |
|---|---|
| spa2/src/main/res/layout/kalendar_layout.xml | Replaces legacy Space with platform android.widget.Space. |
| spa2/src/main/res/layout-land/kalendar_layout.xml | Same Space replacement for landscape layout. |
| spa2/build.gradle | Drops androidx.legacy:legacy-support-v4 dependency. |
| settings.gradle | Adds Foojay toolchains resolver plugin in settings. |
| gradlew.bat | Changes Windows wrapper launch to -jar and clears CLASSPATH. |
| gradlew | Changes Unix wrapper launch to -jar and sets CLASSPATH to an invalid value. |
Review details
Suppressed comments (1)
gradlew:217
- The wrapper invocation mixes
-classpathwith-jarand no longer specifiesorg.gradle.wrapper.GradleWrapperMain. This is non-standard and can cause portability issues; restore the standard wrapper main-class invocation soCLASSPATHis actually used.
set -- \
"-Dorg.gradle.appname=$APP_BASE_NAME" \
-classpath "$CLASSPATH" \
-jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
"$@"
- Files reviewed: 6/7 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+73
to
+77
| set CLASSPATH= | ||
|
|
||
|
|
||
| @rem Execute Gradle | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* |
Comment on lines
+8
to
+10
| plugins { | ||
| id 'org.gradle.toolchains.foojay-resolver-convention' version '0.10.0' | ||
| } |
ap0ught
force-pushed
the
chore/drop-legacy-support
branch
from
September 9, 2026 16:57
0148ef3 to
090f4ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #13