Skip to content

chore: add guardian workflows #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dcreey
Copy link
Contributor

@dcreey dcreey commented Apr 23, 2025

Goal: add an org-level guardian plan/apply that runs on any repo when they change files in .github/config/ directory, plans it in the PR, and then applies it on merge.

Context: https://docs.google.com/document/d/1nJ4wKycxev8d3-FaMwiP4a3YMMVmseofJIPwbwElIaA/edit?resourcekey=0-OYMYvuqjCVlcEbRpvq4O7w&tab=t.0

NOTES:

  • I suspect that this workflow will fail when set as a required org level workflow because of the on::paths setting. I suspect we cannot conditionally execute this workflow if we mark it required.
  • I'm also not sure this will work at all since the apply workflow runs on::push... and the required workflows block PR context. I'm not sure we can make a required workflow run in any context except PR. I will have to test this.

Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - I think these should live in Guardian. Guardian is a standalone software project. Is there a reason we want to keep them separate?

@dcreey
Copy link
Contributor Author

dcreey commented Apr 24, 2025

Hmm - I think these should live in Guardian. Guardian is a standalone software project. Is there a reason we want to keep them separate?

Because the goal is to run these workflows like lint.yml on all repos. This is a specific implementation of guardian for our purposes. The guardian repo should remain general purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants