Add feature tokio-tungstenite/rustls-tls-native-roots to rustls-nativ…#347
Merged
abdolence merged 1 commit intoMar 20, 2026
Conversation
Owner
|
Hejsan, thanks for alerting me - I didn't find there was a missing feature. These TLS combinations drive me crazy all the time recently in all my projects. |
abdolence
approved these changes
Mar 20, 2026
Contributor
Author
|
Oh btw, I just realized that the tokio-tungstenite feature rustls-native-certs is pulled in by rustls-tls-native-roots, so I suppose that rustls-native-certs could be removed as a dependency. |
Owner
|
No worries, I'll fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket example doesn't work out of the box it would seem due to TLS not being setup, I'm not sure if there's suggested way to setup TLS but I couldn't find anything for the socket example or in the book?
Adding this dependency to the rustls-native-certs feature makes it work on Arch Linux and MacOS.
I did see that this was explicitly removed in #342 and that one should use rustls-native-certs, but that doesn't seem to work since this feature isn't included.
As it is right now I have to pull in tokio-tungstenite with the same version and that feature included for my test project that depends on slack-morphism.