chore: fix signature of functions that can produce null terms#44
Open
AdrienChampion wants to merge 2 commits into
Open
chore: fix signature of functions that can produce null terms#44AdrienChampion wants to merge 2 commits into
AdrienChampion wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solverfunctions dealing with QE, interpolants, and abducts can produce null-terms to signify the result does not exist/the incremental production of the result is done. This PR fixes the signatures of these functions so that they produceOption Term-s:noneif the result-term isnull, the term otherwise.