chore: add ESLint, Python CI, and consolidate test/audit fixes#23
Draft
Tamsi wants to merge 2 commits into
Draft
chore: add ESLint, Python CI, and consolidate test/audit fixes#23Tamsi wants to merge 2 commits into
Tamsi wants to merge 2 commits into
Conversation
- Stub VITE_LC_ENABLE_TEAM_AUTH in firebase-config test so cloud-defaults fallback is exercised under Vitest (non-PROD environment). - Replace hardcoded Paris timezone assertion with a locale-agnostic regex in use-daily-analysis test. - Add GitHub Actions workflow: npm ci, audit, test, and build in ui/. - Bump undici to 7.28.0 and apply minor npm dependency updates. - Rebuild dashboard/dist bundle after dependency refresh. Co-authored-by: Tamsi <Tamsi@users.noreply.github.com>
- Add ESLint flat config (typescript-eslint + react-hooks) with pragmatic rule overrides for the existing codebase; npm run lint allows warnings. - Add Prettier config and format scripts (not enforced in CI yet). - Add pyproject.toml with optional [test] dependencies for CI. - Add scripts/run-ci-tests.sh targeting 208 Hermes-free unit tests. - Extend GitHub Actions with npm run lint and a python job. - Ignore *.egg-info/ build artifacts. Co-authored-by: Tamsi <Tamsi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the previous CI/test work (#22) with ESLint/Prettier tooling and a Python test harness.
UI tooling
typescript-eslint,react-hooks,react-refresh)format/format:checkscriptsnpm run lint— 0 errors (48 warnings tolerated on legacy code)npm run typecheck— available locally (pre-existing TS errors, not gated in CI)Python CI
pyproject.tomlwith[test]optional dependenciesscripts/run-ci-tests.sh— 208 Hermes-free unit tests (cloud_api + curated delivery_runtime + plugin smoke)pythonjob in GitHub ActionsAlso included (from #22)
undici7.28.0 security bump + minor npm updatesTest plan
npm audit— 0 vulnerabilitiesnpm run lint— 0 errorsnpm test— 164/164npm run build— OK./scripts/run-ci-tests.sh— 208 passedNotes
test_agent_surfaces.pyandtest_mr_publication_flow.pyexcluded from CI due to SQLite isolation issues when run in batch.