Skip to content

Align Expo standards and fix onboarding Apple icon#1

Merged
abed42 merged 5 commits into
mainfrom
chore/expo-standards-alignment
Jul 10, 2026
Merged

Align Expo standards and fix onboarding Apple icon#1
abed42 merged 5 commits into
mainfrom
chore/expo-standards-alignment

Conversation

@abed42

@abed42 abed42 commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move EAS config and workflows to the Expo app root
  • Declare native SDKs in the app manifest with wrapper peer dependencies
  • Keep RevenueCat inert when the native module is missing
  • Fix the invisible Apple icon on the onboarding sign-in button

Test plan

  • Payments tests pass
  • Typecheck and Biome on touched surfaces
  • iOS dev client rebuild verified

Made with Cursor

abed42 and others added 5 commits July 9, 2026 14:30
Distinguish missing-key and stale-binary states so optional payments never crash app startup and the paywall gives an actionable rebuild path.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep EAS configuration and native SDK governance inside apps/mobile while preserving agent-friendly vendor wrappers and complete optional-vendor removal.

Co-authored-by: Cursor <cursoragent@cursor.com>
Run Biome after dependency installation so anchor-based source surgery always leaves generated variants lint-clean.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep removed-vendor scaffolds free of references to packages the wizard deletes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the private-use glyph with the tinted apple.png asset so the logo stays visible on the black button.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@abed42
abed42 merged commit 3bae5c9 into main Jul 10, 2026
1 check passed
@abed42
abed42 deleted the chore/expo-standards-alignment branch July 10, 2026 17:39
abed42 added a commit that referenced this pull request Jul 11, 2026
Tester finding #1 asked for test/typecheck/lint on design-system; lint was
under-delivered — turbo lint only ran apps/mobile's biome check from that
directory, so packages/* and scripts/ were never linted in CI (proof: an
unorganized import had already drifted into packages/payments). Root
lint:root task (biome check .) now feeds turbo lint via //#lint:root.
Vendored .agents/ skills and the generated skills-lock.json are excluded —
third-party/machine-written content, already stripped from scaffolds.

Reported-by: Ion Petropoulos
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
abed42 added a commit that referenced this pull request Jul 12, 2026
Tester finding #1 asked for test/typecheck/lint on design-system; lint was
under-delivered — turbo lint only ran apps/mobile's biome check from that
directory, so packages/* and scripts/ were never linted in CI (proof: an
unorganized import had already drifted into packages/payments). Root
lint:root task (biome check .) now feeds turbo lint via //#lint:root.
Vendored .agents/ skills and the generated skills-lock.json are excluded —
third-party/machine-written content, already stripped from scaffolds.

Reported-by: Ion Petropoulos
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant