fix(providers): use nullish coalescing for config defaults#196
fix(providers): use nullish coalescing for config defaults#196abhay-ramesh merged 2 commits intomainfrom
Conversation
The provider config builder used || to fall back to defaults, which silently overrode falsy values like false, 0, and "". This meant forcePathStyle: false and useSSL: false were ignored and replaced with defaults. Switch to ?? so only null/undefined trigger fallback.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 10 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Fixes
||to??in the provider config builder. The||operator treatsfalse,0, and""as falsy and falls through to defaults, silently overriding explicit user config:Affected configs:
forcePathStyle: false— needed for virtual-hosted-style URLs (DigitalOcean Spaces, Backblaze B2)useSSL: false— needed for local MinIO without TLSHow was it tested?