fix(ingestion): classify request-like client calls#1744
Conversation
|
Someone is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
CI Report✅ All checks passed Pipeline Status
Test Results
✅ All 10066 tests passed 5 test(s) skipped — expand for details
Code CoverageTests
📋 View full run · Generated by CI |
5a7f89c to
8af46f3
Compare
8af46f3 to
6656f35
Compare
|
Claude finished @magyargergo's task in 9m 9s —— View job Deep Production-Readiness Review — PR #1744Tasks:
Review bar for this PRReviewed against Problem being solvedIssue #692: Current PR stateOpen, ready for review, base Merge status and mergeabilityCI is green per the GitHub Actions bot. The PR branch is clean — Repository history considered
Branch hygiene assessmentPass with one concern. The two merge-from-main commits are harmless and scoped to Go and Spring, not to fetch-call extraction. The only out-of-scope change is Understanding of the changeCore change (
Wiring ( Data flow confirmed correct for the primary case: Route suppression confirmed: FindingsFinding 1 — Language-agnostic import regex scan (DoD §2.6 violation)Risk: Evidence found: Recommended fix: Gate the call to JS/TS/Vue-like languages, e.g.: const JS_TS_LANGS = new Set([SupportedLanguages.TypeScript, SupportedLanguages.JavaScript, SupportedLanguages.Vue]);
const requestLikeBindings = JS_TS_LANGS.has(language)
? collectRequestLikeImportBindings(file.content)
: new Set<string>();Or move the empty-set result upstream before the query loop. A similar gate should be applied in Blocks merge: maybe — DoD §2.6 is explicit: "No repeated avoidable work, unnecessary scans." For large repos with mostly Java/Go/Python files this adds measurable overhead. Not catastrophic (fast regex no-ops), but a clear DoD violation. Fix this → Finding 2 —
|
|
@JaysonAlbert Could you please look into claude's findings ? 🙏 |
|
Thanks for the review. I pushed a follow-up commit (
|
Background
This refreshes the still-useful part of closed, unmerged PR #698 for issue #692 against current
main. Currentmainprevents common request-like member calls from becoming provider routes, but importedrequest.get/post/put/delete/patch(...)calls still do not become consumerFETCHESedges.Changes
umi-requestand localrequesthelpers.request.get('/api/items')createsFETCHESwhilerequest.post('/api/client-only')does not createRoute/HANDLES_ROUTEprovider artifacts.Validation
cd gitnexus && npx vitest run test/integration/resolvers/express-routes.test.tscd gitnexus && npx tsc --noEmitcd gitnexus && npm run format:checknode gitnexus/dist/cli/index.js analyze --force --index-only --name request-like-clients-refresh .node gitnexus/dist/cli/index.js detect-changes --repo request-like-clients-refresh(medium risk; expected ingestion fetch-call symbols)Notes
Issue #692 is already closed, but the full consumer-link behavior from #698 was not present on current
main.