fix(python): scope-resolution coverage gaps — F57, F58, F61 (#1932) by prajapatisparsh · Pull Request #1964 · abhigyanpatwari/GitNexus

prajapatisparsh · 2026-06-01T11:26:03Z

Closes #1932.
F57: heritage patterns for qualified/subscripted bases
F58: decorator patterns for nested-attribute decorators
F61: lambda as @scope.function
F59 already closed by #1920, F60 legacy-only

…patwari#1932) F57: heritage patterns for qualified/subscripted bases F58: decorator patterns for nested-attribute decorators F61: lambda captured as @scope.function F59 already closed by abhigyanpatwari#1920, F60 legacy-only

vercel · 2026-06-01T11:26:08Z

@prajapatisparsh is attempting to deploy a commit to the NexusCore Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2026-06-01T12:01:26Z

CI Report

✅ All checks passed

Pipeline Status

Stage	Status	Details
✅ Typecheck	`success`	tsc --noEmit
✅ Tests	`success`	unit tests, 3 platforms
✅ E2E	`success`	gitnexus-web changes only

Test Results

Tests	Passed	Failed	Skipped	Duration
10782	10772	0	10	643s

✅ All 10772 tests passed

10 test(s) skipped — expand for details

COBOL pipeline benchmark > scales with file count
C# pipeline benchmark > scales with file count — namespaces spread across the solution
C# pipeline benchmark > scales with file count — all types in one (global) namespace bucket
C# pipeline benchmark > scales with file count — all types in one (named) namespace bucket
Go pipeline benchmark > scales with file count (workers enabled)
Go pipeline benchmark — worker pool (issue Worker idle timeout kills long Go scope extraction and surfaces as Napi::Error during analyze #1848) > does not quarantine the large generated Go file on sub-batch idle timeout
PHP pipeline benchmark > scales with file count (workers enabled)
Ruby pipeline benchmark > scales with file count (workers enabled)
Rust pipeline benchmark > scales with file count (workers enabled)
buildTypeEnv > known limitations (documented skip tests) > Ruby block parameter: users.each { |user| } — closure param inference, different feature

Code Coverage

Tests

Metric	Coverage	Covered	Base	Delta	Status
Statements	80.35%	37500/46667	79.84%	📈 +0.5	🟢 ████████████████░░░░
Branches	68.91%	23873/34642	68.5%	📈 +0.4	🟢 █████████████░░░░░░░
Functions	85.45%	3885/4546	84.94%	📈 +0.5	🟢 █████████████████░░░
Lines	83.92%	33743/40205	83.36%	📈 +0.6	🟢 ████████████████░░░░

_{📋 View full run · Generated by CI}

magyargergo · 2026-06-01T16:07:40Z

Could you please resolve the conflict?

magyargergo

Methods

5 Claude lanes (gitnexus-risk-architect, gitnexus-test-ci-verifier, ce-correctness-reviewer, ce-adversarial-reviewer) + Codex (codex-rescue). Codex was live. Two engines are Claude under different personas; strong signal = Codex + Claude agreement on decorator wiring and golden drift.

Final verdict

not production-ready

Capture/query work for F58/F61 and new tests are directionally right, but F58 does not reach ReferenceSites, the python-captures golden is still stale (reproduced locally), and the PR lowers global coverage thresholds while CI remains red. F57 query patterns are largely redundant on this branch because merged main already ships synthesizePythonInheritanceReferences in captures.ts (#1951)—qualified bases do emit inherits sites today; the PR’s @heritage.* tags remain topic: unknown in scope-extractor.ts.

Merge state classification

checks failing

Branch hygiene classification

merge-from-main commit present but harmless and merge-safe

Review bar for this PR

Issue #1932: close Python scope-resolution gaps F57 (heritage shapes), F58 (decorators), F61 (lambda scopes). Expect capture + registry-primary graph effects, golden/bench parity, and green CI.

Current PR state

5 files in GitHub diff: query.ts, integration tests, heritage.py, bench fingerprint, vitest.config.ts.
10/10 new integration tests pass locally (emitPythonScopeCaptures only).
Cross-repo head from prajapatisparsh/fix/python-parsing-coverage.

Merge status and mergeability

mergeable: MERGEABLE, mergeStateStatus: BLOCKED (required checks). Two merge-from-main commits on the branch; no conflict markers in the reviewed diff.

Repository history considered

#1951 / #1956 migrated inheritance to scope-resolution (captures.ts synthesis)—landed via merge from main, not in this PR’s 5-file diff.
Prior CI on older SHA showed golden failure; latest run still has benchmarks FAIL (coverage/scope-parity pending at review time).

PR-specific assessment

Parser / scope query (`query.ts`)

F61 lambda (lambda) @scope.function: creates Function scopes — solid [code-read].
F58 decorators @reference.decorator.call: emitted by tree-sitter, dropped in pass5CollectReferences because referenceKindFromAnchor has no decorator head (scope-extractor.ts:1027-1048, guard at :990-991). [code-read] extractParsedFile(@login_required) → referenceSites: [].
F57 @heritage.* in query: matches are topicOf → unknown (scope-extractor.ts:259-270) and skipped. However, captures.ts:208-225 synthesizes @reference.inherits from AST on merged head — class A(mod.Base) → {name:'Base', kind:'inherits'} [code-read]. PR query heritage is not what fixes EXTENDS on current head.
Duplicate captures: @api.v1.endpoint → 2 identical @reference.decorator.call rows (patterns at :260-270 overlap) [reproduced].

Tests / CI

P0 Golden expected-captures.json not updated; python-captures-golden.test.ts fails (189 vs 190 keys; synthetic:dao-20 +20 groups from new decorator captures) [reproduced].
P2 vitest.config.ts lowers all four coverage floors by 1 point—risks masking regressions while golden is still red.
Tests never call extractParsedFile / assert graph edges for F58.

Back-and-forth avoided by verifying

Ran python-parsing-coverage.test.ts (pass) and python-captures-golden.test.ts (fail).
emitPythonScopeCaptures duplicate count for nested decorators.
extractParsedFile for decorator and class A(mod.Base) on PR head.
bench/python-scope/measure.mjs --check PASS locally; CI benchmarks job FAIL on latest SHA (log pending).

Open questions

Is lowering vitest coverage thresholds intentional for capture inflation, or should golden regeneration make that unnecessary?
Should F58 use @reference.call.member / .free instead of a new decorator tag?

Inline findings (summary)

P0 — @reference.decorator.call never becomes a ReferenceSite.
P1 — Overlapping nested-decorator patterns double-match.
P2 — Tests only assert capture layer; F58 untested end-to-end.
P2 — Coverage thresholds lowered in vitest.config.ts.

Lower priority (body only)

Regenerate test/fixtures/python-captures-golden/expected-captures.json (UPDATE_GOLDEN=1 …) — blocks merge.
heritage.py unused by tests; PYTHON_QUERIES decorator block still single-hop identifier receiver (legacy routes)—out of this diff.
@app.route still produces module-scoped @reference.call.member for inner route call (pre-existing path).

Refuted / validated

Refuted as sole F57 fix: query-only @heritage.* without pipeline wiring (superseded on branch by captures.ts synthesis from main).
Validated: F61 lambda scope counts; heritage capture text for bare/qualified/subscripted snippets.

Automated multi-tool digest (1 Codex + 5 Claude lanes)—verify before acting.

magyargergo · 2026-06-01T17:27:47Z

  return_type: (type) @type-binding.type) @type-binding.return

+;; Decorators — simple @decorator
+(decorator


P0 — F58 never reaches the graph [code-read]

Trigger: Any @login_required / @app.route processed through registry-primary Python.

Evidence: Tag @reference.decorator.call → referenceKindFromAnchor parses head decorator (not in switch) → undefined → pass5CollectReferences skips (scope-extractor.ts:990-991, 1027-1048). extractParsedFile on @login_required → referenceSites: [].

Fix: Rename to existing @reference.call.free / .member, or add case 'decorator': return 'call' + pipeline test asserting referenceSites.

Blocks merge: yes (claimed F58 behavior not end-to-end)

@prajapatisparsh you missed this

magyargergo · 2026-06-01T17:27:47Z

+    attribute: (identifier) @reference.name)) @reference.decorator.call
+
+;; Decorators — @a.b.decorator (nested attributes)
+(decorator


P1 — duplicate decorator captures [reproduced]

Trigger: @api.v1.endpoint on a function.

Evidence: Pattern at :260-264 (object: (_)) and :266-270 (object: (attribute)) both match nested attributes → 2 identical @reference.decorator.call rows (same range). Tests use toBeGreaterThanOrEqual(1) so this is invisible.

Fix: Make patterns disjoint (e.g. restrict :260 to object: (identifier) only) or dedupe in captures.ts; assert toBe(1) in F58 nested test.

Blocks merge: maybe (becomes edge inflation if F58 wiring is fixed)

@prajapatisparsh this was missed too

…lden regeneration, thresholds reverted, baseline update

github-actions · 2026-06-01T18:24:59Z

✨ PR Autofix

Found fixable formatting / unused-import issues across 14 changed lines. Comment /autofix on this PR to apply them, or run npm run lint:fix && npm run format locally.

{"schema":"gitnexus.pr-autofix/v2","state":"fixes-available","pr_number":1964,"changed_lines":14,"head_sha":"42be3b2211b4c8da01988e116470ffc5d492b17d","run_id":"26773747052","apply_command":"/autofix"}

prajapatisparsh and others added 2 commits June 1, 2026 16:56

Merge branch 'main' into fix/python-parsing-coverage

0424555

chore(bench): update Python scope-capture baseline after F57/F58/F61

4a73e3d

prajapatisparsh and others added 2 commits June 1, 2026 22:44

chore: lower coverage thresholds after F57/F58/F61 query additions

989bb22

Merge branch 'main' into fix/python-parsing-coverage

d0a1e9d

magyargergo reviewed Jun 1, 2026

View reviewed changes

P0-P6 review fixes: F58 decorator wiring, deduplication, e2e test, go…

42be3b2

…lden regeneration, thresholds reverted, baseline update

github-advanced-security AI found potential problems Jun 1, 2026

View reviewed changes

Comment thread gitnexus/test/integration/resolvers/python-parsing-coverage.test.ts Fixed

Comment thread gitnexus/test/integration/resolvers/python-parsing-coverage.test.ts Fixed

Comment thread gitnexus/test/integration/resolvers/python-parsing-coverage.test.ts Fixed

prajapatisparsh and others added 3 commits June 2, 2026 00:21

chore: remove unused imports from python-parsing-coverage test

aa996fb

Merge branch 'main' into fix/python-parsing-coverage

3533382

Merge branch 'main' into fix/python-parsing-coverage

fb0dbaa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(python): scope-resolution coverage gaps — F57, F58, F61 (#1932)#1964

fix(python): scope-resolution coverage gaps — F57, F58, F61 (#1932)#1964
prajapatisparsh wants to merge 9 commits into
abhigyanpatwari:mainfrom
prajapatisparsh:fix/python-parsing-coverage

prajapatisparsh commented Jun 1, 2026

Uh oh!

vercel Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026 •

edited

Loading

Uh oh!

magyargergo commented Jun 1, 2026

Uh oh!

magyargergo left a comment

Uh oh!

magyargergo Jun 1, 2026

Uh oh!

magyargergo Jun 1, 2026

Uh oh!

magyargergo Jun 1, 2026

Uh oh!

magyargergo Jun 1, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

prajapatisparsh commented Jun 1, 2026

Uh oh!

vercel Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Report

Pipeline Status

Test Results

Code Coverage

Tests

Uh oh!

magyargergo commented Jun 1, 2026

Uh oh!

magyargergo left a comment

Choose a reason for hiding this comment

Methods

Final verdict

Merge state classification

Branch hygiene classification

Review bar for this PR

Current PR state

Merge status and mergeability

Repository history considered

PR-specific assessment

Parser / scope query (query.ts)

Tests / CI

Back-and-forth avoided by verifying

Open questions

Inline findings (summary)

Lower priority (body only)

Refuted / validated

Uh oh!

magyargergo Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

magyargergo Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

magyargergo Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

magyargergo Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026

✨ PR Autofix

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 1, 2026 •

edited

Loading

Parser / scope query (`query.ts`)