Skip to content

Fix Flaky Submit Test #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhinav merged 2 commits into from
Feb 3, 2026
Merged

Fix Flaky Submit Test #1011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27b729c
fix flaky stack_submit_with_assignees test
ed-irl Feb 3, 2026
d2abcb7
test: fix flaky stack_submit_with_assignees
ed-irl Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions testdata/script/stack_submit_with_assignees.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ git config spice.submit.assignees spice
# submit the entire stack from the middle.
git checkout feature1
gs stack submit --fill --assign alex --assign beatrice,cameron
cmpenv stderr $WORK/golden/submit-log.txt
stderr 'Created #1'
stderr 'Created #2'
stderr 'Created #3'

shamhub dump changes
cmpenvJSON stdout $WORK/golden/start.json
Expand All @@ -61,10 +63,6 @@ This is feature 2
-- repo/feature3.txt --
This is feature 3

-- golden/submit-log.txt --
INF Created #1: $SHAMHUB_URL/alice/example/change/1
INF Created #2: $SHAMHUB_URL/alice/example/change/2
INF Created #3: $SHAMHUB_URL/alice/example/change/3
-- golden/start.json --
[
{
Expand Down
Loading