forge: extract shared URL parsing utilities#1013
Merged
abhinav merged 1 commit intoabhinav:mainfrom Feb 7, 2026
Merged
Conversation
Contributor
Author
|
@abhinav since this is not user facing, if you could add the skip changelog label that would be helpful 🙏 |
Owner
|
Done! FYI you can also add I'll review and merge tonight or this weekend, but one early piece of feedback: |
ed-irl
force-pushed
the
gs/forge-url-refactor
branch
from
245b5fd to
24529d0
Compare
Extract duplicate URL parsing code from github and gitlab forges into a new internal/forge/urls package. The new package provides: - HasGitProtocol: check if URL has a known git protocol - Parse: parse git remote URLs, normalizing SCP-style SSH syntax - StripDefaultPort: remove default ports when base URL doesn't specify one - MatchesHost: check if hosts match including subdomains - ExtractPath: extract owner/repo from URL path This reduces code duplication and will allow the bitbucket forge to reuse the same URL parsing logic.
ed-irl
force-pushed
the
gs/forge-url-refactor
branch
from
24529d0 to
f6e1cf1
Compare
abhinav
approved these changes
Feb 7, 2026
Comment on lines
+350
to
+358
|
|
||
| Do not pluralize package names. | ||
| Use singular nouns or compound names instead. | ||
|
|
||
| ``` | ||
| // BAD: pluralized package names | ||
| urls | ||
| utils | ||
| helpers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicate URL parsing code from github and gitlab forges into a new internal/forge/urls package.
The new package provides:
This reduces code duplication and will allow the bitbucket forge to reuse the same URL parsing logic.