fix: enhance error diagnostics for multi-line expressions#36
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Enhances sel-checker diagnostics so caret-based error locations from cel-js can be converted into absolute offsets within multi-line SEL expressions, improving editor highlighting and error reporting for multi-line inputs.
Changes:
- Extend caret-position parsing to account for reported line numbers and compute document-absolute
{from,to}offsets. - Update diagnostics extraction to pass the original expression into position parsing.
- Add unit tests covering multi-line offsets and fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/sel-checker/src/checker/diagnostics.ts | Compute absolute offsets using parsed `> N |
| packages/sel-checker/src/checker/diagnostics.spec.ts | Add tests for multi-line absolute offset computation and out-of-range fallback. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const lineMatch = codeLine.match(/^>\s+(\d+)\s*\|/); | ||
| const lineNumber = lineMatch ? Number(lineMatch[1]) : 1; | ||
|
|
||
| // Compute the byte offset where this line starts in the expression |
| * positions relative to the error line; we need document-absolute offsets. | ||
| */ | ||
| const lineMatch = codeLine.match(/^>\s+(\d+)\s*\|/); | ||
| const lineNumber = lineMatch ? Number(lineMatch[1]) : 1; |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.