Skip to content

DockerFile Added #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WTFitsmemyself wants to merge 4 commits into from
Closed

DockerFile Added #127

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16adafc
DockerFile Added
WTFitsmemyself Jul 7, 2021
14866fd
Update Dockerfile
WTFitsmemyself Jul 7, 2021
0b4b45c
Update Dockerfile
WTFitsmemyself Jul 19, 2021
6f45637
Merge branch 'abishekvashok:master' into master
WTFitsmemyself Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
FROM alpine:3.13
RUN apk add cmatrix
CMD [ "cmatrix" ]

#### Litle doc ####
# Now with command `docker build -t <NameOfImage:Tag> .` An image will create that the main work is to run Cmatrix
# After creation with command `docker run -it <NameOfImage:Tag>` Cmatrix will run :)

#### For @abishekvashok ####
# at first wanted to install from source code but can't autoconf in alpine and this way is neater
Copy link
Owner

@abishekvashok abishekvashok Jul 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, just a simple query...
Hey, I feel the source code installation makes more sense. I don't know much about docker, but I can see an autoconf package for alpine available here: https://pkgs.alpinelinux.org/package/v3.3/main/x86/autoconf

Also, I would be happy, if you could move this comment out of the docker file to your PR or commit body, for someone else, when they view it, it kinda doesn't make sense. But if you want, we can keep it there. What do you think?

Copy link
Author

@WTFitsmemyself WTFitsmemyself Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Welcome ,
Yes absolutely , installing from source code is best and essential but we add DockerFile for people who want to see a preview of the code and don't want to install in Host OS computer so they run docker and see the code in a container .

I use linux alpine because (because it is a 1.82MB linux :D) and it fits for everyone that has an unstable network who can't download Ubuntu image (about 30 - 50 MB) And also I see the Alpine link but the best way for docker to use an image is to get it from hub.docker.

OK, of course I add doc in commit body :)

Copy link
Owner

@abishekvashok abishekvashok Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 mb seems reasonable if we can move the step of compilation there. We can use a release which has a configure so we won't need autotools.