Widen Prettier scope to cover all files#39
Merged
mschristensen merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
3 times, most recently
from
2d6895f to
e43e5dd
Compare
lawrence-forooghian
changed the title
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
2 times, most recently
from
7c39fdd to
be67322
Compare
lawrence-forooghian
changed the title
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
from
be67322 to
a50dbd0
Compare
Coverage Report
File CoverageNo changed files found. |
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
from
a50dbd0 to
2b1e40f
Compare
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
from
2b1e40f to
87df05b
Compare
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
from
87df05b to
8d61bbb
Compare
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
from
8d61bbb to
74ff9a2
Compare
lawrence-forooghian
force-pushed
the
fix-prettier-scope
branch
from
74ff9a2 to
b3bab61
Compare
lawrence-forooghian
requested review from
a team,
VeskeR and
owenpearson
and removed request for
a team and
owenpearson
mschristensen
force-pushed
the
fix-prettier-scope
branch
from
b3bab61 to
3a56365
Compare
Switch format scripts from explicit path lists to `prettier .` (matching ably-js's approach). Submodules (ably-common, specification) are excluded via .prettierignore. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mschristensen
force-pushed
the
fix-prettier-scope
branch
from
3a56365 to
878d09d
Compare
mschristensen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
format:checkandformatscripts only coveredsrc/and demo source directories, so a bunch of files e.g. tests were never checked by CI. But, even more annoyingly, I found Claude would sometimes explicitly runprettier --writeon excluded files that it edited, thus introducing diff noise.Instead, match ably-js's approach of formatting everything (relying on Prettier's automatic ignoral of gitignored stuff).
🤖 Generated with Claude Code