Conversation
This was originally intended as a "fix compiler crash in Xcode 16.3" release, but actually it turns out 0.2.0 compiles fine in Xcode 16.3 (since we hadn't yet introduced typed throws). So instead it's now a "@mainactor and typed throws" release. Documentation changes are in ably/docs#2532.
WalkthroughThis update bumps the SDK version to 0.3.0. The CHANGELOG now includes a version entry with details about two changes: main protocols are annotated with Changes
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
Sources/AblyChat/Version.swift (1)
1-10: Reminder on TODO comment.
There is a TODO on line 3 regarding the chat-js implementation for sending up agent info. While this change isn’t directly related to the version bump, please ensure that this temporary copy is tracked for future refactoring or proper integration.CHANGELOG.md (2)
7-8: Stylistic suggestion for conciseness.
The list items currently read:
- "All of the main protocols in the SDK are now marked as
@MainActor, to simplify the experience of using the SDK. (#261)"- "All of the errors thrown by the SDK are now explicitly typed as
ARTErrorInfo. (#234)"Consider removing the redundant “of” to make the wording a bit more concise. For example:
- "Main protocols in the SDK are now marked as
@MainActorto simplify usage. (#261)"- "Errors thrown by the SDK are now explicitly typed as
ARTErrorInfo. (#234)"🧰 Tools
🪛 LanguageTool
[style] ~7-~7: Consider removing “of” to be more concise
Context: ...swift/tree/0.3.0) ## What's Changed - All of the main protocols in the SDK are now marke...(ALL_OF_THE)
[style] ~8-~8: Consider removing “of” to be more concise
Context: ...e experience of using the SDK. (#261) - All of the errors thrown by the SDK are now explic...(ALL_OF_THE)
10-10: Markdown formatting improvement.
The bare URL in the changelog entry can trigger markdown lint warnings. Consider formatting it as a markdown link. For example, change:-**Full Changelog**: https://github.com/ably/ably-chat-swift/compare/0.2.0...0.3.0 +**Full Changelog**: [Full Changelog](https://github.com/ably/ably-chat-swift/compare/0.2.0...0.3.0)This will improve readability and adhere to markdown best practices.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
10-10: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)Sources/AblyChat/Version.swift(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[style] ~7-~7: Consider removing “of” to be more concise
Context: ...swift/tree/0.3.0) ## What's Changed - All of the main protocols in the SDK are now marke...
(ALL_OF_THE)
[style] ~8-~8: Consider removing “of” to be more concise
Context: ...e experience of using the SDK. (#261) - All of the errors thrown by the SDK are now explic...
(ALL_OF_THE)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
10-10: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (19)
- GitHub Check: Example app, tvOS (Xcode 16.3)
- GitHub Check: Example app, tvOS (Xcode 16.2)
- GitHub Check: Example app, iOS (Xcode 16.3)
- GitHub Check: Xcode, tvOS (Xcode 16.3)
- GitHub Check: Xcode,
releaseconfiguration, tvOS (Xcode 16.3) - GitHub Check: Example app, iOS (Xcode 16.2)
- GitHub Check: Xcode, tvOS (Xcode 16.2)
- GitHub Check: Example app, macOS (Xcode 16.3)
- GitHub Check: Xcode,
releaseconfiguration, tvOS (Xcode 16.2) - GitHub Check: Xcode, iOS (Xcode 16.3)
- GitHub Check: Xcode,
releaseconfiguration, iOS (Xcode 16.3) - GitHub Check: Xcode, iOS (Xcode 16.2)
- GitHub Check: Xcode,
releaseconfiguration, iOS (Xcode 16.2) - GitHub Check: Xcode, macOS (Xcode 16.3)
- GitHub Check: Xcode,
releaseconfiguration, macOS (Xcode 16.3) - GitHub Check: Xcode,
releaseconfiguration, macOS (Xcode 16.2) - GitHub Check: Xcode, macOS (Xcode 16.2)
- GitHub Check: SPM (Xcode 16.3)
- GitHub Check: SPM (Xcode 16.2)
🔇 Additional comments (2)
Sources/AblyChat/Version.swift (1)
7-7: Version constant update approved.
The version constant is now correctly updated to"0.3.0"to match the proposed release version.CHANGELOG.md (1)
3-6: New version entry for 0.3.0 added.
The new section for version 0.3.0, including the header and the "What's Changed" subsection, is correctly formatted and reflects the intended release notes.
This was originally intended as a "fix compiler crash in Xcode 16.3" release, but actually it turns out 0.2.0 compiles fine in Xcode 16.3 (since we hadn't yet introduced typed throws). So instead it's now a "
@MainActorand typed throws" release.Documentation changes are in ably/docs#2532.
Summary by CodeRabbit
New Features
Documentation