Skip to content

Research for CI SPM check hangs randomly on Xcode 16.1-3#297

Closed
maratal wants to merge 2 commits intomainfrom
295-tests-hanging-on-CI-research
Closed

Research for CI SPM check hangs randomly on Xcode 16.1-3#297
maratal wants to merge 2 commits intomainfrom
295-tests-hanging-on-CI-research

Conversation

@maratal
Copy link
Copy Markdown
Collaborator

@maratal maratal commented Jun 15, 2025

Research for #295

Despite the fact that the first attempt was successful, the second one hanged with Xcode 16.2

This PR has a single dummy change after 4a93bad commit

Also tried with a860449 commit, still hanged with Xcode 16.2

Locally 200 iterations run just fine:

◇ Iteration 200 ended after 0.463 seconds.
✔ Test run with 26400 tests passed after 86.009 seconds.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch 295-tests-hanging-on-CI-research

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 15, 2025 20:15 Inactive
@maratal maratal force-pushed the 295-tests-hanging-on-CI-research branch from 1c826e0 to 5bc7ee3 Compare June 15, 2025 20:42
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 15, 2025 20:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 15, 2025 20:49 Inactive
@maratal
Copy link
Copy Markdown
Collaborator Author

maratal commented Jun 15, 2025

WDYT @lawrence-forooghian

@maratal maratal force-pushed the 295-tests-hanging-on-CI-research branch from 5bc7ee3 to 380c2dc Compare June 15, 2025 21:12
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 15, 2025 21:13 Inactive
@maratal maratal changed the title Temporary commit and title Research for CI SPM check hangs rundomly on Xcode 16.1-3 Jun 15, 2025
@maratal maratal changed the title Research for CI SPM check hangs rundomly on Xcode 16.1-3 Research for CI SPM check hangs randomly on Xcode 16.1-3 Jun 15, 2025
@lawrence-forooghian
Copy link
Copy Markdown
Collaborator

lawrence-forooghian commented Jun 17, 2025

We need to figure out which tests are hanging and whether it's consistently the same tests that are hanging; at least then we can disable those tests for now to unblock ourselves. Unfortunately the output of swift test doesn't show when a test completes, which makes this hard. So either we need to:

  1. figure out some way of getting it to log when a test completes (Googled it, found nothing; asked ChatGPT and it invented some nonsense)
  2. otherwise, maybe we could try adding a time limit to all of our tests (e.g. write @Suite(.timeLimit(.minutes(2))) in all of our tests files; AFAIK there isn't a way to set a time limit globally?), and then hanging tests will trigger a timeout

@lawrence-forooghian
Copy link
Copy Markdown
Collaborator

lawrence-forooghian commented Jun 17, 2025

Asked about logging of test case completion in https://forums.swift.org/t/how-to-get-swift-test-to-log-when-a-test-case-completes/80524 by the way; would suggest trying with a time limit in the meantime @maratal

@maratal maratal force-pushed the 295-tests-hanging-on-CI-research branch from 380c2dc to 1612da0 Compare June 17, 2025 20:14
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 17, 2025 20:30 Inactive
@maratal maratal force-pushed the 295-tests-hanging-on-CI-research branch from 78cb8c8 to 4d5e260 Compare June 17, 2025 21:02
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 17, 2025 21:04 Inactive
@maratal maratal force-pushed the 295-tests-hanging-on-CI-research branch 2 times, most recently from 4d5e260 to 1d5a3c3 Compare June 17, 2025 23:32
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 17, 2025 23:33 Inactive
@maratal maratal force-pushed the 295-tests-hanging-on-CI-research branch from 1d5a3c3 to 1964f42 Compare June 17, 2025 23:38
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 17, 2025 23:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 18, 2025 00:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 18, 2025 01:41 Inactive
@lawrence-forooghian
Copy link
Copy Markdown
Collaborator

Asked about logging of test case completion in https://forums.swift.org/t/how-to-get-swift-test-to-log-when-a-test-case-completes/80524 by the way; would suggest trying with a time limit in the meantime @maratal

They replied there; apparently you can do swift test --verbose and it'll tell you when tests complete.

@github-actions github-actions bot temporarily deployed to staging/pull/297/AblyChat June 18, 2025 13:30 Inactive
@maratal
Copy link
Copy Markdown
Collaborator Author

maratal commented Jul 7, 2025

Tmp fix - #299

@lawrence-forooghian
Copy link
Copy Markdown
Collaborator

Closing this one in favour of #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants