[ECO-5342] Refactor wrap Message in the Messages subscription in MessageEvent#310
Merged
[ECO-5342] Refactor wrap Message in the Messages subscription in MessageEvent#310
Conversation
WalkthroughThe codebase was refactored to introduce a new event type, Changes
Sequence Diagram(s)sequenceDiagram
participant ClientApp
participant Messages
participant Subscriber
ClientApp->>Messages: subscribe(callback: (ChatMessageEvent) -> Void)
Messages-->>Subscriber: on event (created/updated/deleted)
Messages->>Subscriber: callback(ChatMessageEvent)
Subscriber->>ClientApp: handle event.type and event.message
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were identified. Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (7)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ttypic
force-pushed
the
ECO-5342/message-event
branch
from
876b7d7 to
0e04e87
Compare
ttypic
force-pushed
the
ECO-5342/message-event
branch
from
0e04e87 to
fa273a3
Compare
ttypic
changed the title
maratal
approved these changes
Jul 3, 2025
Collaborator
maratal
left a comment
maratal
left a comment
There was a problem hiding this comment.
Approving on the basis of straightforward of this PR and tests passing.
The only thing questionable is why we have ChatMessageEvent but Message as a chat message? Shouldn't it be the same (i.e. ChatMessage or MessageEvent)?
Contributor
Author
|
@maratal It's an exception, |
umair-ably
approved these changes
Jul 4, 2025
ttypic
force-pushed
the
ECO-5342/occupancy-event-refactoring
branch
from
56d4c8a to
9c7597d
Compare
…eEvent` [ECO-5342]
ttypic
force-pushed
the
ECO-5342/message-event
branch
from
fa273a3 to
ff1511b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor wrap Message in the Messages subscription in ChatMessageEvent
ECO-5342
Summary by CodeRabbit
New Features
Bug Fixes
Tests