Skip to content

Treat warnings as errors via package manifest#365

Merged
lawrence-forooghian merged 1 commit intomainfrom
warnings-as-errors-via-SPM
Oct 6, 2025
Merged

Treat warnings as errors via package manifest#365
lawrence-forooghian merged 1 commit intomainfrom
warnings-as-errors-via-SPM

Conversation

@lawrence-forooghian
Copy link
Copy Markdown
Collaborator

@lawrence-forooghian lawrence-forooghian commented Oct 3, 2025

Note: This PR is based on top of #364; please review that one first.

This is a new feature of Swift 6.2 and greatly simplifies building the library (and means we'll now catch warnings when doing platform-specific builds via xcodebuild too, which we couldn't before).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 3, 2025

Warning

Rate limit exceeded

@lawrence-forooghian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 21 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5009845 and a78e4ae.

📒 Files selected for processing (6)
  • .github/workflows/check.yaml (2 hunks)
  • Package.swift (1 hunks)
  • Sources/BuildTool/XcodeRunner.swift (0 hunks)
  • Tests/AblyChatTests/DefaultRoomOccupancyTests.swift (1 hunks)
  • Tests/AblyChatTests/JSONValueTests.swift (2 hunks)
  • Tests/AblyChatTests/MessageSubscriptionAsyncSequenceTests.swift (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch warnings-as-errors-via-SPM

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot temporarily deployed to staging/pull/365/AblyChat October 3, 2025 16:24 Inactive
This is a new feature of Swift 6.2 and greatly simplifies building the
library (and means we'll now catch warnings when doing platform-specific
builds via xcodebuild too, which we couldn't before).
@lawrence-forooghian lawrence-forooghian merged commit 8405a3e into main Oct 6, 2025
31 of 33 checks passed
@lawrence-forooghian lawrence-forooghian deleted the warnings-as-errors-via-SPM branch October 6, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants