Get rid of ChatError

Sources/AblyChat/AblyCocoaExtensions/InternalAblyCocoaTypes.swift

@@ -164,7 +164,7 @@ internal final class InternalRealtimeClientAdapter<Underlying: ProxyRealtimeClie
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 }
@@ -234,7 +234,7 @@ internal final class InternalRealtimePresenceAdapter<Underlying: RealtimePresenc
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -252,7 +252,7 @@ internal final class InternalRealtimePresenceAdapter<Underlying: RealtimePresenc
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -268,7 +268,7 @@ internal final class InternalRealtimePresenceAdapter<Underlying: RealtimePresenc
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -284,7 +284,7 @@ internal final class InternalRealtimePresenceAdapter<Underlying: RealtimePresenc
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -300,7 +300,7 @@ internal final class InternalRealtimePresenceAdapter<Underlying: RealtimePresenc
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -358,7 +358,7 @@ internal final class InternalRealtimeChannelAdapter<Underlying: ProxyRealtimeCha
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -374,7 +374,7 @@ internal final class InternalRealtimeChannelAdapter<Underlying: ProxyRealtimeCha
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 
@@ -390,7 +390,7 @@ internal final class InternalRealtimeChannelAdapter<Underlying: ProxyRealtimeCha
                 }
             }.get()
         } catch {
-            throw error.toInternalError()
+            throw InternalError.fromAblyCocoa(error)
         }
     }
 

Sources/AblyChat/DefaultMessageReactions.swift

@@ -41,7 +41,7 @@ internal final class DefaultMessageReactions: MessageReactions {
     internal func delete(fromMessageWithSerial messageSerial: String, params: DeleteMessageReactionParams) async throws(ARTErrorInfo) {
         let reactionType = params.type ?? options.defaultMessageReactionType
         if reactionType != .unique, params.name == nil {
-            throw ARTErrorInfo(chatError: .unableDeleteReactionWithoutName(reactionType: reactionType.rawValue))
+            throw InternalError.internallyThrown(.unableDeleteReactionWithoutName(reactionType: reactionType.rawValue)).toARTErrorInfo()
         }
         do {
             let apiParams: ChatAPI.DeleteMessageReactionParams = .init(

Sources/AblyChat/DefaultMessages.swift

@@ -179,11 +179,11 @@ internal final class DefaultMessages: Messages {
                         continuation.resume(returning: .success(subscriptionPoint))
                     } else {
                         logger.log(message: "Channel is attached, but attachSerial is not defined", level: .error)
-                        continuation.resume(returning: .failure(ARTErrorInfo(chatError: .attachSerialIsNotDefined).toInternalError()))
+                        continuation.resume(returning: .failure(InternalError.internallyThrown(.attachSerialIsNotDefined)))
                     }
                 case .failed, .suspended:
                     // TODO: Revisit as part of https://github.com/ably-labs/ably-chat-swift/issues/32
-                    let error = ARTErrorInfo(chatError: .channelFailedToAttach(cause: stateChange.reason)).toInternalError()
+                    let error = InternalError.internallyThrown(.channelFailedToAttach(cause: stateChange.reason))
                     logger.log(message: "\(error)", level: .error)
                     continuation.resume(returning: .failure(error))
                 default: