Conversation
…a view breaks clicks on macos/tvOS. There is no quick way of implementing this without flipping views, so I'll just remove those targets for now.
WalkthroughThe example iOS project's Xcode build configuration is updated to remove macOS and tvOS platform support. SUPPORTED_PLATFORMS is reduced to iPhone-only targets, and TARGETED_DEVICE_FAMILY is adjusted from 1,2,3 to 1,2, effectively narrowing device compatibility to iPhone and iPad. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Example/AblyChatExample.xcodeproj/project.pbxproj (2)
304-308: Platform removal implemented correctly; consider cleaning up related settings.The changes to
SUPPORTED_PLATFORMSandTARGETED_DEVICE_FAMILYcorrectly remove macOS and tvOS support as intended. Both values are now limited to iPhone and iPad devices only.However, several related configuration settings are now unused and could be removed for clarity:
- Line 299:
MACOSX_DEPLOYMENT_TARGET(macOS-specific)- Line 298:
LD_RUNPATH_SEARCH_PATHS[sdk=macosx*](macOS-specific)- Line 308:
TVOS_DEPLOYMENT_TARGET(tvOS-specific)Apply this diff to clean up unused platform-specific settings in the Debug configuration:
LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks"; - "LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "@executable_path/../Frameworks"; - MACOSX_DEPLOYMENT_TARGET = 14.0; MARKETING_VERSION = 1.0; PRODUCT_BUNDLE_IDENTIFIER = com.ably.AblyChatExample; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = auto; SUPPORTED_PLATFORMS = "iphoneos iphonesimulator"; SUPPORTS_MACCATALYST = NO; SWIFT_EMIT_LOC_STRINGS = YES; TARGETED_DEVICE_FAMILY = "1,2"; - TVOS_DEPLOYMENT_TARGET = 17.0;
347-351: Release configuration matches Debug; same cleanup applies.The Release configuration changes are consistent with the Debug configuration, correctly limiting platform support to iPhone and iPad simulators and devices.
The same unused platform-specific settings can be cleaned up here as well for consistency.
Apply this diff to clean up unused platform-specific settings in the Release configuration:
LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks"; - "LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "@executable_path/../Frameworks"; - MACOSX_DEPLOYMENT_TARGET = 14.0; MARKETING_VERSION = 1.0; PRODUCT_BUNDLE_IDENTIFIER = com.ably.AblyChatExample; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = auto; SUPPORTED_PLATFORMS = "iphoneos iphonesimulator"; SUPPORTS_MACCATALYST = NO; SWIFT_EMIT_LOC_STRINGS = YES; TARGETED_DEVICE_FAMILY = "1,2"; - TVOS_DEPLOYMENT_TARGET = 17.0;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Example/AblyChatExample.xcodeproj/project.pbxproj(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Example/**
📄 CodeRabbit inference engine (CLAUDE.md)
Maintain the example SwiftUI app under the Example/ directory alongside the workspace AblyChat.xcworkspace
Files:
Example/AblyChatExample.xcodeproj/project.pbxproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Xcode, macOS (Xcode 26.0)
- GitHub Check: Xcode, tvOS (Xcode 26.0)
- GitHub Check: Xcode, iOS (Xcode 26.0)
- GitHub Check: Example app, iOS (Xcode 26.0)
- GitHub Check: Example app, tvOS (Xcode 26.0)
- GitHub Check: Xcode,
releaseconfiguration, iOS (Xcode 26.0) - GitHub Check: SPM,
releaseconfiguration (Xcode 26.0) - GitHub Check: Xcode,
releaseconfiguration, macOS (Xcode 26.0) - GitHub Check: Xcode,
releaseconfiguration, tvOS (Xcode 26.0) - GitHub Check: Example app, macOS (Xcode 26.0)
- GitHub Check: SPM (Xcode 26.0)
|
Fix is in |
flip()method for easy and smooth adding messages at the bottom of a view breaks clicks on macos/tvOS. There is no quick way of implementing this without flipping views, so I'll just remove those targets for now.Summary by CodeRabbit