Skip to content

Temporary removing macOS and tvOS targets#446

Closed
maratal wants to merge 1 commit intomainfrom
400-tmp-removing-macos-tvos
Closed

Temporary removing macOS and tvOS targets#446
maratal wants to merge 1 commit intomainfrom
400-tmp-removing-macos-tvos

Conversation

@maratal
Copy link
Copy Markdown
Collaborator

@maratal maratal commented Oct 21, 2025

flip() method for easy and smooth adding messages at the bottom of a view breaks clicks on macos/tvOS. There is no quick way of implementing this without flipping views, so I'll just remove those targets for now.

Summary by CodeRabbit

  • Chores
    • Updated platform support configuration to target iPhone and iPad devices only, removing macOS and Apple TV platform support.

…a view breaks clicks on macos/tvOS. There is no quick way of implementing this without flipping views, so I'll just remove those targets for now.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 21, 2025

Walkthrough

The example iOS project's Xcode build configuration is updated to remove macOS and tvOS platform support. SUPPORTED_PLATFORMS is reduced to iPhone-only targets, and TARGETED_DEVICE_FAMILY is adjusted from 1,2,3 to 1,2, effectively narrowing device compatibility to iPhone and iPad.

Changes

Cohort / File(s) Summary
Example project build configuration
Example/AblyChatExample.xcodeproj/project.pbxproj
Removed macOS and tvOS support by modifying SUPPORTED_PLATFORMS (now "iphoneos iphonesimulator") and TARGETED_DEVICE_FAMILY (now "1,2") in Debug and Release build configurations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hopping through platforms, we pare it down,
No macOS mansions or tvOS town,
iPhone and iPad, our focused delight,
Simpler, slimmer, and perfectly right! 🍎

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Temporary removing macOS and tvOS targets" accurately reflects the main changes in the changeset. The modifications remove macOS from SUPPORTED_PLATFORMS and reduce TARGETED_DEVICE_FAMILY from "1,2,3" to "1,2" (where 3 represents Apple TV), which directly aligns with the stated objective of temporarily removing macOS and tvOS platform support due to issues with the flip() method. The title is concise, specific, and clearly communicates the primary change without being vague or generic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 400-tmp-removing-macos-tvos

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
Example/AblyChatExample.xcodeproj/project.pbxproj (2)

304-308: Platform removal implemented correctly; consider cleaning up related settings.

The changes to SUPPORTED_PLATFORMS and TARGETED_DEVICE_FAMILY correctly remove macOS and tvOS support as intended. Both values are now limited to iPhone and iPad devices only.

However, several related configuration settings are now unused and could be removed for clarity:

  • Line 299: MACOSX_DEPLOYMENT_TARGET (macOS-specific)
  • Line 298: LD_RUNPATH_SEARCH_PATHS[sdk=macosx*] (macOS-specific)
  • Line 308: TVOS_DEPLOYMENT_TARGET (tvOS-specific)

Apply this diff to clean up unused platform-specific settings in the Debug configuration:

 				LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks";
-				"LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "@executable_path/../Frameworks";
-				MACOSX_DEPLOYMENT_TARGET = 14.0;
 				MARKETING_VERSION = 1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = com.ably.AblyChatExample;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SDKROOT = auto;
 				SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
 				SUPPORTS_MACCATALYST = NO;
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				TARGETED_DEVICE_FAMILY = "1,2";
-				TVOS_DEPLOYMENT_TARGET = 17.0;

347-351: Release configuration matches Debug; same cleanup applies.

The Release configuration changes are consistent with the Debug configuration, correctly limiting platform support to iPhone and iPad simulators and devices.

The same unused platform-specific settings can be cleaned up here as well for consistency.

Apply this diff to clean up unused platform-specific settings in the Release configuration:

 				LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks";
-				"LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "@executable_path/../Frameworks";
-				MACOSX_DEPLOYMENT_TARGET = 14.0;
 				MARKETING_VERSION = 1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = com.ably.AblyChatExample;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SDKROOT = auto;
 				SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
 				SUPPORTS_MACCATALYST = NO;
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				TARGETED_DEVICE_FAMILY = "1,2";
-				TVOS_DEPLOYMENT_TARGET = 17.0;
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d7cc8ee and 91f64cb.

📒 Files selected for processing (1)
  • Example/AblyChatExample.xcodeproj/project.pbxproj (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Example/**

📄 CodeRabbit inference engine (CLAUDE.md)

Maintain the example SwiftUI app under the Example/ directory alongside the workspace AblyChat.xcworkspace

Files:

  • Example/AblyChatExample.xcodeproj/project.pbxproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Xcode, macOS (Xcode 26.0)
  • GitHub Check: Xcode, tvOS (Xcode 26.0)
  • GitHub Check: Xcode, iOS (Xcode 26.0)
  • GitHub Check: Example app, iOS (Xcode 26.0)
  • GitHub Check: Example app, tvOS (Xcode 26.0)
  • GitHub Check: Xcode, release configuration, iOS (Xcode 26.0)
  • GitHub Check: SPM, release configuration (Xcode 26.0)
  • GitHub Check: Xcode, release configuration, macOS (Xcode 26.0)
  • GitHub Check: Xcode, release configuration, tvOS (Xcode 26.0)
  • GitHub Check: Example app, macOS (Xcode 26.0)
  • GitHub Check: SPM (Xcode 26.0)

@maratal
Copy link
Copy Markdown
Collaborator Author

maratal commented Oct 21, 2025

Fix is in fix-example-app-mac branch.

@maratal maratal closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant