[ECO-5702] Fix Xcode 26.4 compilation error#482
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR updates CI infrastructure to support Xcode 26.4/Swift 6.2 by upgrading macOS runner versions, fixes a Swift 6.2 actor-isolation compilation error in TypingOperationQueue by adding Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
24ab27a to
d64a1bf
Compare
The error was: > TypingOperationQueue.swift:96:38: error: sending 'pendingRequest' risks causing data races > await pendingRequest.performOperation() > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ > > note: sending main actor-isolated 'pendingRequest' to nonisolated instance method 'performOperation()' risks causing data races between nonisolated and main actor-isolated uses A Swift 6.3 issue, it would seem. I guess that perhaps the nested Request type no longer inherits the main actor isolation of its containing type? Resolves ably/ably-cocoa#2202 (reporter opened issue there).
f577318 to
b8c7443
Compare
MainActor issue
ttypic
left a comment
There was a problem hiding this comment.
LGTM, just a thought: maybe it's worth to run on macos-latest? Can it help us find future bugs with new version of Xcode faster?
|
Unfortunately and likewise the default version of xcode that the runners use is not the latest either; e.g. it's currently 26.2: https://github.com/actions/runner-images/blob/main/images/macos/macos-26-Readme.md We could have a CI job that also tests against whatever the default version of Xcode is too, so that we will eventually catch issues introduced by new versions of Xcode (once they become the default) |
|
I think another problem is the fact that we only run our CI jobs when we actually make a change, so in periods where there isn't much change on a given SDK it can take a while to find out; maybe we should consider nightly builds of everything too |
Resolves ably/ably-cocoa#2202. See commit message for more details.
Summary by CodeRabbit
Release Notes